Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 11419253: google_apis: Clean up gdata_wapi_operations.h (Closed)

Created:
8 years ago by satorux1
Modified:
8 years ago
Reviewers:
kinaba
CC:
chromium-reviews, achuith+watch_chromium.org
Visibility:
Public.

Description

google_apis: Clean up gdata_wapi_operations.h - Add and fix comments - Make some members private - Make some members const - Give better names to parameters (in particular document_url -> content_url/edit_url) BUG=163544, 163558 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170466

Patch Set 1 : polish #

Total comments: 2

Patch Set 2 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+174 lines, -127 lines) Patch
M chrome/browser/google_apis/gdata_wapi_operations.h View 1 21 chunks +147 lines, -100 lines 0 comments Download
M chrome/browser/google_apis/gdata_wapi_operations.cc View 17 chunks +27 lines, -27 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
satorux1
8 years ago (2012-11-30 07:54:50 UTC) #1
kinaba
This is great. LGTM. https://codereview.chromium.org/11419253/diff/2001/chrome/browser/google_apis/gdata_wapi_operations.h File chrome/browser/google_apis/gdata_wapi_operations.h (right): https://codereview.chromium.org/11419253/diff/2001/chrome/browser/google_apis/gdata_wapi_operations.h#newcode499 chrome/browser/google_apis/gdata_wapi_operations.h:499: // If upload is complete, ...
8 years ago (2012-11-30 09:57:25 UTC) #2
kinaba
...LG except the build break :p,
8 years ago (2012-11-30 10:01:15 UTC) #3
satorux1
oops, let me fix and re-upload...
8 years ago (2012-11-30 10:04:08 UTC) #4
kinaba
lgtm
8 years ago (2012-11-30 10:09:00 UTC) #5
satorux1
fixed the build too. https://codereview.chromium.org/11419253/diff/2001/chrome/browser/google_apis/gdata_wapi_operations.h File chrome/browser/google_apis/gdata_wapi_operations.h (right): https://codereview.chromium.org/11419253/diff/2001/chrome/browser/google_apis/gdata_wapi_operations.h#newcode499 chrome/browser/google_apis/gdata_wapi_operations.h:499: // If upload is complete, ...
8 years ago (2012-11-30 10:09:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/satorux@chromium.org/11419253/8001
8 years ago (2012-11-30 13:30:10 UTC) #7
commit-bot: I haz the power
8 years ago (2012-11-30 17:05:01 UTC) #8
Message was sent while issue was closed.
Change committed as 170466

Powered by Google App Engine
This is Rietveld 408576698