Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 11419249: Add gyp dependency on proguard flags. (Closed)

Created:
8 years ago by shashi
Modified:
8 years ago
Reviewers:
cjhopman, Yaron
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add gyp dependency on proguard flags. Apks currently are not rebuilt when proguard flags change, add gyp dependency on proguard flags. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170820

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M build/java_apk.gypi View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
shashi
8 years ago (2012-11-30 03:34:31 UTC) #1
cjhopman
lgtm
8 years ago (2012-12-01 02:37:13 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
8 years ago (2012-12-01 02:39:20 UTC) #3
shashi
yfriedman: committer approval.
8 years ago (2012-12-01 02:41:52 UTC) #4
Yaron
lgtm
8 years ago (2012-12-03 17:10:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shashishekhar@chromium.org/11419249/1
8 years ago (2012-12-03 17:10:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shashishekhar@chromium.org/11419249/1
8 years ago (2012-12-03 18:54:30 UTC) #7
commit-bot: I haz the power
8 years ago (2012-12-03 22:08:38 UTC) #8
Message was sent while issue was closed.
Change committed as 170820

Powered by Google App Engine
This is Rietveld 408576698