Decouple workspace animation from other actions on windows (e.g. hide/show), so that animations can…

ash/wm/window_animations.h

Index: ash/wm/window_animations.h
diff --git a/ash/wm/window_animations.h b/ash/wm/window_animations.h
index 5be60fa004d947d38ee6aac8d9de1f854b9366c1..ac1c34c6b1ab62fa3fac4261b3547501cdf67e70 100644
--- a/ash/wm/window_animations.h
+++ b/ash/wm/window_animations.h
@@ -6,6 +6,7 @@
 #define ASH_WM_WINDOW_ANIMATIONS_H_
 
 #include "ash/ash_export.h"
+#include "ui/gfx/transform.h"
 #include "ui/views/corewm/window_animations.h"
 
 namespace aura {
@@ -29,6 +30,13 @@ enum WindowVisibilityAnimationType {
   WINDOW_VISIBILITY_ANIMATION_TYPE_BRIGHTNESS_GRAYSCALE
 };
 
+// Direction Ash-specific window animations used in workspaces and lock/unlock

[Daniel Erat, 2012/11/30 14:33:08]

nit: s/Direction/Direction for/

+// animations.
+enum AshWindowScaleType {

[Daniel Erat, 2012/11/30 14:33:08]

LayerScaleAnimationDirection?

+  ASH_WINDOW_SCALE_ABOVE,

[Daniel Erat, 2012/11/30 14:33:08]

LAYER_SCALE_ANIMATION_ABOVE

+  ASH_WINDOW_SCALE_BELOW,
+};
+
 // Animate a cross-fade of |window| from its current bounds to |new_bounds|.
 ASH_EXPORT void CrossFadeToBounds(aura::Window* window,
                                   const gfx::Rect& new_bounds);
@@ -56,6 +64,10 @@ ASH_EXPORT std::vector<ui::LayerAnimationSequence*>
 CreateBrightnessGrayscaleAnimationSequence(float target_value,
                                            base::TimeDelta duration);
 
+// Returns scale related to the specified AshWindowScaleType.

[Daniel Erat, 2012/11/30 14:33:08]

i don't understand this comment; this method returns void

+ASH_EXPORT void ApplyAshWindowAnimationScale(ui::Layer* layer,

[Daniel Erat, 2012/11/30 14:33:08]

SetTransformForScaleAnimation()?

("ash" seems redundant, and you're animating a layer, not a window)

+                                             AshWindowScaleType type);
+
 }  // namespace ash