Decouple workspace animation from other actions on windows (e.g. hide/show), so that animations can…

ash/wm/window_animations.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ASH_WM_WINDOW_ANIMATIONS_H_
 #define ASH_WM_WINDOW_ANIMATIONS_H_
 
 #include "ash/ash_export.h"
+#include "ui/gfx/transform.h"
 #include "ui/views/corewm/window_animations.h"
 
 namespace aura {
 class Window;
 }
 namespace ui {
 class Layer;
 }
 
 // This is only for animations specific to Ash. For window animations shared
 // with desktop Chrome, see ui/views/corewm/window_animations.h.
 namespace ash {
 
 // An extension of the window animations provided by CoreWm. These should be
 // Ash-specific only.
 enum WindowVisibilityAnimationType {
   // Window scale/rotates down to its launcher icon.
   WINDOW_VISIBILITY_ANIMATION_TYPE_MINIMIZE =
       views::corewm::WINDOW_VISIBILITY_ANIMATION_MAX,
   // Fade in/out using brightness and grayscale web filters.
   WINDOW_VISIBILITY_ANIMATION_TYPE_BRIGHTNESS_GRAYSCALE
 };
 
+// Direction Ash-specific window animations used in workspaces and lock/unlock

[Daniel Erat, 2012/11/30 14:33:08]

nit: s/Direction/Direction for/

+// animations.
+enum AshWindowScaleType {

[Daniel Erat, 2012/11/30 14:33:08]

LayerScaleAnimationDirection?

+  ASH_WINDOW_SCALE_ABOVE,

[Daniel Erat, 2012/11/30 14:33:08]

LAYER_SCALE_ANIMATION_ABOVE

+  ASH_WINDOW_SCALE_BELOW,
+};
+
 // Animate a cross-fade of |window| from its current bounds to |new_bounds|.
 ASH_EXPORT void CrossFadeToBounds(aura::Window* window,
                                   const gfx::Rect& new_bounds);
 
 // Cross fades |layer| (which is a clone of |window|s layer before it was
 // resized) to |window|s current bounds. |new_workspace| is the Window of the
 // workspace |window| was added to.
 // This takes ownership of |layer|.
 ASH_EXPORT void CrossFadeWindowBetweenWorkspaces(aura::Window* new_workspace,
                                                  aura::Window* window,
                                                  ui::Layer* layer);
 
 // Returns the duration of the cross-fade animation based on the |old_bounds|
 // and |new_bounds| of the window.
 ASH_EXPORT base::TimeDelta GetCrossFadeDuration(const gfx::Rect& old_bounds,
                                                 const gfx::Rect& new_bounds);
 
 ASH_EXPORT bool AnimateOnChildWindowVisibilityChanged(aura::Window* window,
                                                       bool visible);
 
 // Creates vector of animation sequences that lasts for |duration| and changes
 // brightness and grayscale to |target_value|. Caller takes ownership of
 // returned LayerAnimationSequence objects.
 ASH_EXPORT std::vector<ui::LayerAnimationSequence*>
 CreateBrightnessGrayscaleAnimationSequence(float target_value,
                                            base::TimeDelta duration);
 
+// Returns scale related to the specified AshWindowScaleType.

[Daniel Erat, 2012/11/30 14:33:08]

i don't understand this comment; this method returns void

+ASH_EXPORT void ApplyAshWindowAnimationScale(ui::Layer* layer,

[Daniel Erat, 2012/11/30 14:33:08]

SetTransformForScaleAnimation()?

("ash" seems redundant, and you're animating a layer, not a window)

+                                             AshWindowScaleType type);
+
 }  // namespace ash
 
 
 #endif  // ASH_WM_WINDOW_ANIMATIONS_H_