Decouple workspace animation from other actions on windows (e.g. hide/show), so that animations can…

Decouple workspace animation from other actions on windows (e.g. hide/show), so that animations can be used separately.

It would fix focus loss upon locking issue, as well as remove flickering on partial lock/cancel locking.

BUG=162646
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170580

[Denis Kuznetsov (DE-MUC), 2012-11-29 16:00:45]

With this approach there is no need
https://chromiumcodereview.appspot.com/11280188/, so no strange flags will be
required.

[Daniel Erat, 2012-11-29 18:23:03]

(letting Scott look at this one)

[sky, 2012-11-29 19:06:51]

https://chromiumcodereview.appspot.com/11419225/diff/5001/ash/wm/workspace/wo...
File ash/wm/workspace/workspace_animations.cc (right):

https://chromiumcodereview.appspot.com/11419225/diff/5001/ash/wm/workspace/wo...
ash/wm/workspace/workspace_animations.cc:71: if (details.animate_scale || force)
{
Why do we need both force and scale?

https://chromiumcodereview.appspot.com/11419225/diff/5001/ash/wm/workspace/wo...
File ash/wm/workspace/workspace_animations.h (right):

https://chromiumcodereview.appspot.com/11419225/diff/5001/ash/wm/workspace/wo...
ash/wm/workspace/workspace_animations.h:58: ASH_EXPORT void
SetWorkspaceAnimationStartParameters(
As previously mentioned we should not have session state calling 'workspace'
specific animations. Move to a common place that does not have workspace in the
name. I'm fine with putting in window_animations.

[sky, 2012-11-29 19:07:14]

I've removed Dan from this patch.

[Denis Kuznetsov (DE-MUC), 2012-11-30 13:12:47]

Daniel, Scott have day off today, he said he is fine with approach, but wanted
to move code to workspace-agnostic location.
I also made some tweaks from mail discussion (tween type and duration).

[Nikita (slow), 2012-11-30 14:12:12]

+Daniel

[Daniel Erat, 2012-11-30 14:33:08]

I'm out today as well, but LGTM after some comments are addressed.

https://chromiumcodereview.appspot.com/11419225/diff/4002/ash/wm/session_stat...
File ash/wm/session_state_animator.cc (right):

https://chromiumcodereview.appspot.com/11419225/diff/4002/ash/wm/session_stat...
ash/wm/session_state_animator.cc:221: sequence->AddObserver(observer);
fix indenting

https://chromiumcodereview.appspot.com/11419225/diff/4002/ash/wm/window_anima...
File ash/wm/window_animations.cc (right):

https://chromiumcodereview.appspot.com/11419225/diff/4002/ash/wm/window_anima...
ash/wm/window_animations.cc:66: const float kAshWindowScaleAbove = 1.1f;
kLayerScaleAboveSize, kLayerScaleBelowSize

https://chromiumcodereview.appspot.com/11419225/diff/4002/ash/wm/window_anima...
File ash/wm/window_animations.h (right):

https://chromiumcodereview.appspot.com/11419225/diff/4002/ash/wm/window_anima...
ash/wm/window_animations.h:33: // Direction Ash-specific window animations used
in workspaces and lock/unlock
nit: s/Direction/Direction for/

https://chromiumcodereview.appspot.com/11419225/diff/4002/ash/wm/window_anima...
ash/wm/window_animations.h:35: enum AshWindowScaleType {
LayerScaleAnimationDirection?

https://chromiumcodereview.appspot.com/11419225/diff/4002/ash/wm/window_anima...
ash/wm/window_animations.h:36: ASH_WINDOW_SCALE_ABOVE,
LAYER_SCALE_ANIMATION_ABOVE

https://chromiumcodereview.appspot.com/11419225/diff/4002/ash/wm/window_anima...
ash/wm/window_animations.h:67: // Returns scale related to the specified
AshWindowScaleType.
i don't understand this comment; this method returns void

https://chromiumcodereview.appspot.com/11419225/diff/4002/ash/wm/window_anima...
ash/wm/window_animations.h:68: ASH_EXPORT void
ApplyAshWindowAnimationScale(ui::Layer* layer,
SetTransformForScaleAnimation()?

("ash" seems redundant, and you're animating a layer, not a window)

[commit-bot: I haz the power, 2012-11-30 18:27:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/antrim@chromium.org/11419225/7002

[commit-bot: I haz the power, 2012-11-30 20:37:27]

Retried try job too often on win_rel for step(s) content_browsertests

[commit-bot: I haz the power, 2012-11-30 20:49:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/antrim@chromium.org/11419225/7002

[commit-bot: I haz the power, 2012-11-30 22:36:04]

Change committed as 170580