Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 11419218: Use textInputInfo instead of textInputType in getTextInputType (Closed)

Created:
8 years ago by Yusuf
Modified:
8 years ago
Reviewers:
jamesr, James Su
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, cjhopman, aurimas (slooooooooow)
Visibility:
Public.

Description

Use textInputInfo instead of textInputType in getTextInputType For the given repro case, textInputType seems to get stuck in the previous input type whereas textInputInfo is checking whether an editor exists for the focused frame and exiting early with with TextInputType set to None. Switching to using textInputInfo in getTextInputType, as the comments in the header suggests the use of textInputType by itself as an API should be deprecated anyway. BUG=162831 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170558

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M content/renderer/render_widget.cc View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Yusuf
8 years ago (2012-11-29 06:00:02 UTC) #1
jamesr
I'm not familiar enough with IME things to review this. suzhe@, could you look this ...
8 years ago (2012-11-30 02:24:10 UTC) #2
James Su
LGTM. But the implementation of WebViewImpl::textInputInfo() looks not quite good to me, maybe you can ...
8 years ago (2012-11-30 07:50:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusufo@chromium.org/11419218/1
8 years ago (2012-11-30 18:17:28 UTC) #4
commit-bot: I haz the power
Presubmit check for 11419218-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years ago (2012-11-30 18:17:32 UTC) #5
jamesr
owners lgtm for content/renderer
8 years ago (2012-11-30 19:21:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusufo@chromium.org/11419218/1
8 years ago (2012-11-30 19:21:34 UTC) #7
commit-bot: I haz the power
8 years ago (2012-11-30 21:49:31 UTC) #8
Message was sent while issue was closed.
Change committed as 170558

Powered by Google App Engine
This is Rietveld 408576698