Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1338)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11419202: Remove libibus dependency from config relate stuff. (Closed)

Created:
8 years ago by Seigo Nonaka
Modified:
8 years ago
Reviewers:
satorux1
CC:
chromium-reviews, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org
Visibility:
Public.

Description

Remove libibus dependency from config relate stuff. Most of connection management stuff is moved to chromeos/dbus/ibus/ibus_config_client This CL depends https://codereview.chromium.org/11413165/ BUG=158265 TEST=Manually done on lumpy Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170651

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -215 lines) Patch
M chrome/browser/chromeos/input_method/ibus_controller_impl.h View 3 chunks +2 lines, -11 lines 0 comments Download
M chrome/browser/chromeos/input_method/ibus_controller_impl.cc View 12 chunks +45 lines, -204 lines 0 comments Download
M chromeos/dbus/dbus_thread_manager.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
M chromeos/dbus/dbus_thread_manager.cc View 1 4 chunks +8 lines, -0 lines 0 comments Download
M chromeos/dbus/mock_dbus_thread_manager.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chromeos/dbus/mock_dbus_thread_manager_without_gmock.h View 1 4 chunks +7 lines, -0 lines 0 comments Download
M chromeos/dbus/mock_dbus_thread_manager_without_gmock.cc View 1 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Seigo Nonaka
8 years ago (2012-11-28 13:33:06 UTC) #1
satorux1
LGTM
8 years ago (2012-11-28 23:39:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/11419202/1
8 years ago (2012-11-29 02:33:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/11419202/4003
8 years ago (2012-11-30 15:40:32 UTC) #4
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) content_unittests
8 years ago (2012-11-30 16:57:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/11419202/4003
8 years ago (2012-12-01 02:08:41 UTC) #6
commit-bot: I haz the power
8 years ago (2012-12-01 03:51:16 UTC) #7
Message was sent while issue was closed. 
Change committed as 170651

Powered by Google App Engine
This is Rietveld 408576698