Add public accounts to UserManager

chrome/browser/chromeos/login/existing_user_controller.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/login/existing_user_controller.h"
 
 #include <vector>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
@@ skipping 171 matching lines @@
 }
 
 void ExistingUserController::UpdateLoginDisplay(const UserList& users) {
   bool show_users_on_signin;
   UserList filtered_users;
 
   cros_settings_->GetBoolean(kAccountsPrefShowUserNamesOnSignIn,
                              &show_users_on_signin);
   if (show_users_on_signin) {
     for (UserList::const_iterator it = users.begin(); it != users.end(); ++it) {
       // TODO(xiyuan): Clean user profile whose email is not in whitelist.

[pastarmovj, 2012/11/28 09:57:16]

Don't you do the clean up from this TODO in UseRManagerImpl now. Maybe you can
clean up this todo if this is the case.

[bartfab (slow), 2012/11/28 12:30:17]

No, I only clean up device-local accounts that no longer exist. The UserManager
does not reason about the whitelist and hence, will not clean up the users
referenced in this TODO.

-      if (LoginUtils::IsWhitelisted((*it)->email()))
+      if (LoginUtils::IsWhitelisted((*it)->email()) ||
+          (*it)->GetType() != User::USER_TYPE_REGULAR) {
         filtered_users.push_back(*it);
+      }
     }
   }
 
   // If no user pods are visible, fallback to single new user pod which will
   // have guest session link.
   bool show_guest;
   cros_settings_->GetBoolean(kAccountsPrefAllowGuest, &show_guest);
   bool show_users;
   cros_settings_->GetBoolean(kAccountsPrefShowUserNamesOnSignIn, &show_users);
   show_guest &= !filtered_users.empty();
@@ skipping 757 matching lines @@
   // Invalidate OAuth token, since it can't be correct after password is
   // changed.
   UserManager::Get()->SaveUserOAuthStatus(username,
                                           User::OAUTH_TOKEN_STATUS_INVALID);
 
   login_display_->SetUIEnabled(true);
   login_display_->ShowGaiaPasswordChanged(username);
 }
 
 }  // namespace chromeos