Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 11419094: Adds use_default_render_theme to common.gypi so that features.gypi can (Closed)

Created:
8 years, 1 month ago by sky
Modified:
8 years, 1 month ago
Reviewers:
tony
CC:
chromium-reviews
Visibility:
Public.

Description

Adds use_default_render_theme to common.gypi so that features.gypi can use it. Default is set to 0 for now, will change to 1 when land rest of bits. BUG=none TEST=none R=tony@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=168892

Patch Set 1 #

Total comments: 2

Patch Set 2 : os_poxis -> !win #

Patch Set 3 : os_poxis -> !win #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M build/common.gypi View 1 4 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
sky
8 years, 1 month ago (2012-11-20 17:03:20 UTC) #1
tony
https://codereview.chromium.org/11419094/diff/1/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/11419094/diff/1/build/common.gypi#newcode145 build/common.gypi:145: ['use_aura==1 or (os_posix==1 and OS!="mac" and OS!="ios" and OS!="android")', ...
8 years, 1 month ago (2012-11-20 18:11:34 UTC) #2
sky
https://codereview.chromium.org/11419094/diff/1/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/11419094/diff/1/build/common.gypi#newcode145 build/common.gypi:145: ['use_aura==1 or (os_posix==1 and OS!="mac" and OS!="ios" and OS!="android")', ...
8 years, 1 month ago (2012-11-20 18:56:53 UTC) #3
tony
LGTM
8 years, 1 month ago (2012-11-20 19:03:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/11419094/3
8 years, 1 month ago (2012-11-20 19:21:30 UTC) #5
commit-bot: I haz the power
Retried try job too often for step(s) content_browsertests
8 years, 1 month ago (2012-11-20 20:42:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/11419094/3
8 years, 1 month ago (2012-11-20 21:00:34 UTC) #7
commit-bot: I haz the power
8 years, 1 month ago (2012-11-20 22:36:12 UTC) #8
Change committed as 168892

Powered by Google App Engine
This is Rietveld 408576698