content/browser/renderer_host/resource_dispatcher_host_unittest.cc - Issue 11419034: net: Move ownership of UploadDataStream from URLRequestHttpJob to URLRequest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/resource_dispatcher_host_unittest.cc

Issue 11419034: net: Move ownership of UploadDataStream from URLRequestHttpJob to URLRequest (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Fix ASAN Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/web_request/upload_data_presenter.h ('K') | « content/browser/download/download_manager_impl.cc ('k') | net/base/upload_bytes_element_reader.h » ('j') | net/url_request/url_request.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/resource_dispatcher_host_unittest.cc

diff --git a/content/browser/renderer_host/resource_dispatcher_host_unittest.cc b/content/browser/renderer_host/resource_dispatcher_host_unittest.cc

index 513e140a39b2ede45be0bb2d1836b966ae71da3b..437b611572bac8ff4f176dbffb7ac4efab6c5032 100644

--- a/content/browser/renderer_host/resource_dispatcher_host_unittest.cc

+++ b/content/browser/renderer_host/resource_dispatcher_host_unittest.cc

@@ -1291,7 +1291,9 @@ TEST_F(ResourceDispatcherHostTest, CalculateApproximateMemoryCost) {

std::string upload_content;

upload_content.resize(33);

std::fill(upload_content.begin(), upload_content.end(), 'x');

- req.AppendBytesToUpload(upload_content.data(), upload_content.size());

+ scoped_refptr<net::UploadData> upload_data(new net::UploadData());

+ upload_data->AppendBytes(upload_content.data(), upload_content.size());

+ req.set_upload(upload_data);

// Since the upload throttling is disabled, this has no effect on the cost.

EXPECT_EQ(4436,