chrome/browser/extensions/api/web_request/web_request_api_unittest.cc - Issue 11419034: net: Move ownership of UploadDataStream from URLRequestHttpJob to URLRequest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/web_request/web_request_api_unittest.cc

Issue 11419034: net: Move ownership of UploadDataStream from URLRequestHttpJob to URLRequest (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Remove a local variable Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/web_request/web_request_api.cc ('k') | chrome/browser/net/chrome_fraudulent_certificate_reporter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/web_request/web_request_api_unittest.cc

diff --git a/chrome/browser/extensions/api/web_request/web_request_api_unittest.cc b/chrome/browser/extensions/api/web_request/web_request_api_unittest.cc

index 6a7602f5922406ac44549eb521adb14c80473f96..be2c142013b1dfa35034dcf8bc800867cc762362 100644

--- a/chrome/browser/extensions/api/web_request/web_request_api_unittest.cc

+++ b/chrome/browser/extensions/api/web_request/web_request_api_unittest.cc

@@ -488,10 +488,11 @@ void ExtensionWebRequestTest::FireURLRequestWithData(

request.SetExtraRequestHeaderByName(net::HttpRequestHeaders::kContentType,

content_type,

true /* overwrite */);

- request.AppendBytesToUpload(&(bytes_1[0]), bytes_1.size());

- net::UploadData* data = request.get_upload_mutable();

- data->AppendFileRange(::FilePath(), 0, 0, base::Time());

- request.AppendBytesToUpload(&(bytes_2[0]), bytes_2.size());

+ scoped_refptr<net::UploadData> upload_data(new net::UploadData());

+ upload_data->AppendBytes(&(bytes_1[0]), bytes_1.size());

+ upload_data->AppendFileRange(::FilePath(), 0, 0, base::Time());

+ upload_data->AppendBytes(&(bytes_2[0]), bytes_2.size());

+ request.set_upload(upload_data);

ipc_sender_.PushTask(base::Bind(&base::DoNothing));

request.Start();

}