chrome/browser/extensions/api/web_request/upload_data_presenter_unittest.cc - Issue 11419034: net: Move ownership of UploadDataStream from URLRequestHttpJob to URLRequest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/web_request/upload_data_presenter_unittest.cc

Issue 11419034: net: Move ownership of UploadDataStream from URLRequestHttpJob to URLRequest (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Remove a local variable Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/web_request/upload_data_presenter.cc ('k') | chrome/browser/extensions/api/web_request/web_request_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/web_request/upload_data_presenter_unittest.cc

diff --git a/chrome/browser/extensions/api/web_request/upload_data_presenter_unittest.cc b/chrome/browser/extensions/api/web_request/upload_data_presenter_unittest.cc

index 6957e3a3244ca708721e8b76bb0ec85bb78f231b..5e06660718d168b6a2f2f8f76d691a9dfecd84ff 100644

--- a/chrome/browser/extensions/api/web_request/upload_data_presenter_unittest.cc

+++ b/chrome/browser/extensions/api/web_request/upload_data_presenter_unittest.cc

@@ -6,7 +6,7 @@

#include "base/values.h"

#include "chrome/browser/extensions/api/web_request/upload_data_presenter.h"

#include "chrome/browser/extensions/api/web_request/web_request_api_constants.h"

-#include "net/base/upload_element.h"

+#include "net/base/upload_bytes_element_reader.h"

#include "testing/gtest/include/gtest/gtest.h"

using base::BinaryValue;

@@ -24,8 +24,7 @@ namespace extensions {

TEST(WebRequestUploadDataPresenterTest, ParsedData) {

// Input.

const char block[] = "key.with.dots=value";

- net::UploadElement element;

- element.SetToBytes(block, sizeof(block) - 1);

+ net::UploadBytesElementReader element(block, sizeof(block) - 1);

// Expected output.

scoped_ptr<ListValue> values(new ListValue);