Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Side by Side Diff: chrome/browser/automation/url_request_automation_job.cc

Issue 11419034: net: Move ownership of UploadDataStream from URLRequestHttpJob to URLRequest (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Remove a local variable Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/api/web_request/upload_data_presenter.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/automation/url_request_automation_job.h" 5 #include "chrome/browser/automation/url_request_automation_job.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/compiler_specific.h" 8 #include "base/compiler_specific.h"
9 #include "base/message_loop.h" 9 #include "base/message_loop.h"
10 #include "base/time.h" 10 #include "base/time.h"
11 #include "chrome/browser/automation/automation_resource_message_filter.h" 11 #include "chrome/browser/automation/automation_resource_message_filter.h"
12 #include "chrome/common/automation_messages.h" 12 #include "chrome/common/automation_messages.h"
13 #include "content/public/browser/browser_thread.h" 13 #include "content/public/browser/browser_thread.h"
14 #include "content/public/browser/render_view_host.h" 14 #include "content/public/browser/render_view_host.h"
15 #include "content/public/browser/resource_request_info.h" 15 #include "content/public/browser/resource_request_info.h"
16 #include "net/base/host_port_pair.h" 16 #include "net/base/host_port_pair.h"
17 #include "net/base/io_buffer.h" 17 #include "net/base/io_buffer.h"
18 #include "net/base/net_errors.h" 18 #include "net/base/net_errors.h"
19 #include "net/base/upload_bytes_element_reader.h"
20 #include "net/base/upload_data_stream.h"
21 #include "net/base/upload_file_element_reader.h"
19 #include "net/cookies/cookie_monster.h" 22 #include "net/cookies/cookie_monster.h"
20 #include "net/http/http_request_headers.h" 23 #include "net/http/http_request_headers.h"
21 #include "net/http/http_response_headers.h" 24 #include "net/http/http_response_headers.h"
22 #include "net/http/http_util.h" 25 #include "net/http/http_util.h"
23 #include "net/url_request/http_user_agent_settings.h" 26 #include "net/url_request/http_user_agent_settings.h"
24 #include "net/url_request/url_request.h" 27 #include "net/url_request/url_request.h"
25 #include "net/url_request/url_request_context.h" 28 #include "net/url_request/url_request_context.h"
26 29
27 using base::Time; 30 using base::Time;
28 using base::TimeDelta; 31 using base::TimeDelta;
29 using content::BrowserThread; 32 using content::BrowserThread;
30 using content::ResourceRequestInfo; 33 using content::ResourceRequestInfo;
31 34
35 namespace {
36
32 // The list of filtered headers that are removed from requests sent via 37 // The list of filtered headers that are removed from requests sent via
33 // StartAsync(). These must be lower case. 38 // StartAsync(). These must be lower case.
34 static const char* const kFilteredHeaderStrings[] = { 39 const char* const kFilteredHeaderStrings[] = {
35 "connection", 40 "connection",
36 "cookie", 41 "cookie",
37 "expect", 42 "expect",
38 "max-forwards", 43 "max-forwards",
39 "proxy-authorization", 44 "proxy-authorization",
40 "referer", 45 "referer",
41 "te", 46 "te",
42 "upgrade", 47 "upgrade",
43 "via" 48 "via"
44 }; 49 };
45 50
51 // Creates UploadData from UploadDataStream.
52 net::UploadData* CreateUploadData(
53 const net::UploadDataStream* upload_data_stream) {
54 net::UploadData* upload_data = new net::UploadData();
55 const ScopedVector<net::UploadElementReader>& element_readers =
56 upload_data_stream->element_readers();
57 for (size_t i = 0; i < element_readers.size(); ++i) {
58 const net::UploadElementReader* reader = element_readers[i];
59 if (reader->AsBytesReader()) {
60 const net::UploadBytesElementReader* bytes_reader =
61 reader->AsBytesReader();
62 upload_data->AppendBytes(bytes_reader->bytes(), bytes_reader->length());
63 } else if (reader->AsFileReader()) {
64 const net::UploadFileElementReader* file_reader =
65 reader->AsFileReader();
66 upload_data->AppendFileRange(file_reader->path(),
67 file_reader->range_offset(),
68 file_reader->range_length(),
69 file_reader->expected_modification_time());
70 } else {
71 NOTIMPLEMENTED();
72 }
73 }
74 return upload_data;
75 }
76
77 } // namespace
78
46 int URLRequestAutomationJob::instance_count_ = 0; 79 int URLRequestAutomationJob::instance_count_ = 0;
47 bool URLRequestAutomationJob::is_protocol_factory_registered_ = false; 80 bool URLRequestAutomationJob::is_protocol_factory_registered_ = false;
48 81
49 net::URLRequest::ProtocolFactory* URLRequestAutomationJob::old_http_factory_ 82 net::URLRequest::ProtocolFactory* URLRequestAutomationJob::old_http_factory_
50 = NULL; 83 = NULL;
51 net::URLRequest::ProtocolFactory* URLRequestAutomationJob::old_https_factory_ 84 net::URLRequest::ProtocolFactory* URLRequestAutomationJob::old_https_factory_
52 = NULL; 85 = NULL;
53 86
54 URLRequestAutomationJob::URLRequestAutomationJob( 87 URLRequestAutomationJob::URLRequestAutomationJob(
55 net::URLRequest* request, 88 net::URLRequest* request,
(...skipping 400 matching lines...) Expand 10 before | Expand all | Expand 10 after
456 referrer = GURL(); 489 referrer = GURL();
457 } 490 }
458 491
459 // Get the resource type (main_frame/script/image/stylesheet etc. 492 // Get the resource type (main_frame/script/image/stylesheet etc.
460 const ResourceRequestInfo* info = ResourceRequestInfo::ForRequest(request_); 493 const ResourceRequestInfo* info = ResourceRequestInfo::ForRequest(request_);
461 ResourceType::Type resource_type = ResourceType::MAIN_FRAME; 494 ResourceType::Type resource_type = ResourceType::MAIN_FRAME;
462 if (info) { 495 if (info) {
463 resource_type = info->GetResourceType(); 496 resource_type = info->GetResourceType();
464 } 497 }
465 498
499 // Construct UploadData from UploadDataStream.
500 scoped_refptr<net::UploadData> upload_data;
501 if (request_->get_upload())
502 upload_data = CreateUploadData(request_->get_upload());
503
466 // Ask automation to start this request. 504 // Ask automation to start this request.
467 AutomationURLRequest automation_request; 505 AutomationURLRequest automation_request;
468 automation_request.url = request_->url().spec(); 506 automation_request.url = request_->url().spec();
469 automation_request.method = request_->method(); 507 automation_request.method = request_->method();
470 automation_request.referrer = referrer.spec(); 508 automation_request.referrer = referrer.spec();
471 automation_request.extra_request_headers = new_request_headers.ToString(); 509 automation_request.extra_request_headers = new_request_headers.ToString();
472 automation_request.upload_data = request_->get_upload_mutable(); 510 automation_request.upload_data = upload_data;
473 automation_request.resource_type = resource_type; 511 automation_request.resource_type = resource_type;
474 automation_request.load_flags = request_->load_flags(); 512 automation_request.load_flags = request_->load_flags();
475 513
476 DCHECK(message_filter_); 514 DCHECK(message_filter_);
477 message_filter_->Send(new AutomationMsg_RequestStart( 515 message_filter_->Send(new AutomationMsg_RequestStart(
478 tab_, id_, automation_request)); 516 tab_, id_, automation_request));
479 } 517 }
480 518
481 void URLRequestAutomationJob::DisconnectFromMessageFilter() { 519 void URLRequestAutomationJob::DisconnectFromMessageFilter() {
482 if (message_filter_) { 520 if (message_filter_) {
(...skipping 16 matching lines...) Expand all
499 if (!is_done()) { 537 if (!is_done()) {
500 NotifyDone(request_status_); 538 NotifyDone(request_status_);
501 } 539 }
502 // Reset any pending reads. 540 // Reset any pending reads.
503 if (pending_buf_) { 541 if (pending_buf_) {
504 pending_buf_ = NULL; 542 pending_buf_ = NULL;
505 pending_buf_size_ = 0; 543 pending_buf_size_ = 0;
506 NotifyReadComplete(0); 544 NotifyReadComplete(0);
507 } 545 }
508 } 546 }
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/extensions/api/web_request/upload_data_presenter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698