Issue 11419012: Introduce helper functions to test parallel recompilation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11419012: Introduce helper functions to test parallel recompilation. (Closed)

Created:
8 years, 1 month ago by Yang

Modified:
8 years, 1 month ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Introduce helper functions to test parallel recompilation. BUG= Committed: https://code.google.com/p/v8/source/detail?r=12986

Patch Set 1 #

Total comments: 1

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+113 lines, -27 lines)			Patch
M	src/execution.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/flag-definitions.h	View	2 chunks	+4 lines, -1 line	0 comments	Download
M	src/optimizing-compiler-thread.h	View	6 chunks	+8 lines, -1 line	0 comments	Download
M	src/optimizing-compiler-thread.cc	View	3 chunks	+21 lines, -1 line	0 comments	Download
M	src/runtime.h	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	src/runtime.cc	View	1 chunk	+30 lines, -1 line	1 comment	Download
M	src/runtime-profiler.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download
A +	test/mjsunit/manual-parallel-recompile.js	View	1 chunk	+42 lines, -21 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

8 years, 1 month ago (2012-11-16 10:34:01 UTC) #2

lgtm

http://codereview.chromium.org/11419012/diff/1/src/runtime.cc
File src/runtime.cc (right):

http://codereview.chromium.org/11419012/diff/1/src/runtime.cc#newcode8002
src/runtime.cc:8002: "Recompile queue is full."));
nit: I'd prefer to break the line after "Throw("

Expand Messages | Collapse Messages