Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11418312: app_list: Improve initial icon loading. (Closed)

Created:
8 years ago by xiyuan
Modified:
8 years ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, sadrul, ben+watch_chromium.org, benwells
Visibility:
Public.

Description

app_list: Improve initial icon loading. - Creates and populates AppListModel and starts icon loading for current page apps before creating views; - Shows UI when all icons are loaded or a maximum wait time has passed (currently 50ms); BUG=161025 TEST=Bring up app launcher and the app icons should not flash. R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=171299

Patch Set 1 #

Total comments: 2

Patch Set 2 : for #1 #

Total comments: 6

Patch Set 3 : for #2 #

Patch Set 4 : rebase, stop timer when showing widget because no pending icon loads #

Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -33 lines) Patch
M ash/wm/app_list_controller.h View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M ash/wm/app_list_controller.cc View 1 2 3 1 chunk +9 lines, -14 lines 0 comments Download
M ui/app_list/app_list_constants.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/app_list/app_list_constants.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/app_list/app_list_view.h View 3 chunks +24 lines, -2 lines 0 comments Download
M ui/app_list/app_list_view.cc View 1 2 3 6 chunks +109 lines, -11 lines 0 comments Download
M ui/app_list/apps_grid_view.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/app_list/contents_view.cc View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
xiyuan
8 years ago (2012-12-04 18:28:32 UTC) #1
tfarina
https://codereview.chromium.org/11418312/diff/1/ui/app_list/app_list_view.cc File ui/app_list/app_list_view.cc (right): https://codereview.chromium.org/11418312/diff/1/ui/app_list/app_list_view.cc#newcode60 ui/app_list/app_list_view.cc:60: ~IconLoader() { virtual
8 years ago (2012-12-04 19:00:14 UTC) #2
xiyuan
https://codereview.chromium.org/11418312/diff/1/ui/app_list/app_list_view.cc File ui/app_list/app_list_view.cc (right): https://codereview.chromium.org/11418312/diff/1/ui/app_list/app_list_view.cc#newcode60 ui/app_list/app_list_view.cc:60: ~IconLoader() { On 2012/12/04 19:00:14, tfarina wrote: > virtual ...
8 years ago (2012-12-04 19:50:38 UTC) #3
sky
https://codereview.chromium.org/11418312/diff/5001/ui/app_list/app_list_view.cc File ui/app_list/app_list_view.cc (right): https://codereview.chromium.org/11418312/diff/5001/ui/app_list/app_list_view.cc#newcode169 ui/app_list/app_list_view.cc:169: icon_loading_wait_timer_.Start( Should you ignore this if the timer is ...
8 years ago (2012-12-04 22:51:15 UTC) #4
xiyuan
All done. Please take another look. https://codereview.chromium.org/11418312/diff/5001/ui/app_list/app_list_view.cc File ui/app_list/app_list_view.cc (right): https://codereview.chromium.org/11418312/diff/5001/ui/app_list/app_list_view.cc#newcode169 ui/app_list/app_list_view.cc:169: icon_loading_wait_timer_.Start( On 2012/12/04 ...
8 years ago (2012-12-05 00:40:24 UTC) #5
sky
LGTM
8 years ago (2012-12-05 00:55:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xiyuan@chromium.org/11418312/12001
8 years ago (2012-12-05 18:25:07 UTC) #7
commit-bot: I haz the power
8 years ago (2012-12-05 20:38:51 UTC) #8
Message was sent while issue was closed. 
Change committed as 171299

Powered by Google App Engine
This is Rietveld 408576698