Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 11418305: Fix incremental sync behavior of DriveFileSyncService. (Closed)

Created:
8 years ago by tzik
Modified:
8 years ago
Reviewers:
kinuko
CC:
chromium-reviews, tzik+watch_chromium.org, kinuko+watch
Visibility:
Public.

Description

Fix incremental sync behavior of DriveFileSyncService. This change contains: - check the presence of the metadata entry before delete it, - +1 for start of changestamp to fetch to prevent fetching a change multiple times. BUG=156041 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170934

Patch Set 1 #

Total comments: 2

Patch Set 2 : drop unreached case #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -5 lines) Patch
M chrome/browser/sync_file_system/drive_file_sync_service.cc View 1 5 chunks +9 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tzik
PTAL
8 years ago (2012-12-04 08:35:48 UTC) #1
kinuko
lgtm mod 1 nit https://codereview.chromium.org/11418305/diff/1/chrome/browser/sync_file_system/drive_file_sync_service.cc File chrome/browser/sync_file_system/drive_file_sync_service.cc (right): https://codereview.chromium.org/11418305/diff/1/chrome/browser/sync_file_system/drive_file_sync_service.cc#newcode1087 chrome/browser/sync_file_system/drive_file_sync_service.cc:1087: CompleteRemoteSync(param.Pass(), fileapi::SYNC_STATUS_OK); Could this happen? ...
8 years ago (2012-12-04 08:55:42 UTC) #2
tzik
Thanks! https://codereview.chromium.org/11418305/diff/1/chrome/browser/sync_file_system/drive_file_sync_service.cc File chrome/browser/sync_file_system/drive_file_sync_service.cc (right): https://codereview.chromium.org/11418305/diff/1/chrome/browser/sync_file_system/drive_file_sync_service.cc#newcode1087 chrome/browser/sync_file_system/drive_file_sync_service.cc:1087: CompleteRemoteSync(param.Pass(), fileapi::SYNC_STATUS_OK); On 2012/12/04 08:55:42, kinuko wrote: > ...
8 years ago (2012-12-04 09:14:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/11418305/4001
8 years ago (2012-12-04 09:14:53 UTC) #4
commit-bot: I haz the power
8 years ago (2012-12-04 11:57:46 UTC) #5
Message was sent while issue was closed.
Change committed as 170934

Powered by Google App Engine
This is Rietveld 408576698