Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Side by Side Diff: chrome/browser/android/voice_search_tab_helper.cc

Issue 114183006: Changes to enable HTML5 autoplay for voice search. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "chrome/browser/android/voice_search_tab_helper.h"
6
7 #include "chrome/browser/google/google_util.h"
8 #include "content/public/browser/render_view_host.h"
9 #include "content/public/browser/web_contents.h"
10 #include "jni/VoiceSearchTabHelper_jni.h"
11 #include "webkit/common/webpreferences.h"
12
13 using content::WebContents;
14
15 // Register native methods
16 bool RegisterVoiceSearchTabHelper(JNIEnv* env) {
17 return RegisterNativesImpl(env);
18 }
19
20 static void UpdateAutoplayStatus(JNIEnv* env,
21 jobject obj,
22 jobject j_web_contents) {
23 WebContents* web_contents = WebContents::FromJavaWebContents(j_web_contents);
24 content::RenderViewHost* host = web_contents->GetRenderViewHost();
David Trainor- moved to gerrit 2013/12/30 18:14:30 IIRC they're refactoring RenderViewHost to RenderF
apiccion 2013/12/31 18:52:46 The PSA is here: https://groups.google.com/a/chrom
apiccion 2014/01/02 17:59:09 They say it will probably move into WebContents si
25 WebPreferences prefs = host->GetWebkitPreferences();
26
27 // Handle the case where media autoplay has been enabled from the command
28 // line. Or some other override is otherwise in place. This currently fixes
29 // performance tests (see tools/perf/benchmarks/media.py line 33).
30 //
31 // Note that GetWekitPreferences() is 'stateless'. It returns the default
32 // webkit preferences configuration from command line switches.
33 if (prefs.user_gesture_required_for_media_playback == false)
34 return;
35
36 prefs.user_gesture_required_for_media_playback =
37 !google_util::IsGoogleSearchUrl(web_contents->GetLastCommittedURL());
38 host->UpdateWebkitPreferences(prefs);
39 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698