Issue 11418292: [Android WebView] Plumb WebContentsDelegate::CloseContents to embedder.

Issue 11418292: [Android WebView] Plumb WebContentsDelegate::CloseContents to embedder. (Closed)

Created:
8 years ago by benm (inactive)

Modified:
8 years ago

Reviewers:
joth, mkosiba (inactive)

CC:
chromium-reviews, android-webview-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Android WebView] Plumb WebContentsDelegate::CloseContents to embedder. This allows us to support the Android WebChromeClient.onCloseWindow API. Android bots green NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170935

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -4 lines)			Patch
M	android_webview/java/src/org/chromium/android_webview/AwContentsClient.java	View		3 chunks	+3 lines, -2 lines	0 comments	Download
M	android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegate.java	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	android_webview/javatests/src/org/chromium/android_webview/test/NullContentsClient.java	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	android_webview/native/aw_web_contents_delegate.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	android_webview/native/aw_web_contents_delegate.cc	View	1	4 chunks	+18 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

joth

lgtm % bug https://codereview.chromium.org/11418292/diff/1/android_webview/native/aw_web_contents_delegate.cc File android_webview/native/aw_web_contents_delegate.cc (right): https://codereview.chromium.org/11418292/diff/1/android_webview/native/aw_web_contents_delegate.cc#newcode108 android_webview/native/aw_web_contents_delegate.cc:108: Java_AwWebContentsDelegate_closeContents(env, GetJavaDelegate(env).obj()); here and in fn. ...

8 years ago (2012-12-03 17:45:52 UTC) #2

benm (inactive)

https://codereview.chromium.org/11418292/diff/1/android_webview/native/aw_web_contents_delegate.cc File android_webview/native/aw_web_contents_delegate.cc (right): https://codereview.chromium.org/11418292/diff/1/android_webview/native/aw_web_contents_delegate.cc#newcode108 android_webview/native/aw_web_contents_delegate.cc:108: Java_AwWebContentsDelegate_closeContents(env, GetJavaDelegate(env).obj()); Good catch. will fix up both.

8 years ago (2012-12-03 17:47:18 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benm@chromium.org/11418292/7

8 years ago (2012-12-04 10:28:58 UTC) #4

Message was sent while issue was closed.

Change committed as 170935

Expand Messages | Collapse Messages