Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 11418284: Use chroot name instead of full path chroot command (Closed)

Created:
8 years ago by Wei James(wistoch)
Modified:
8 years ago
Reviewers:
tim ansell; mmoss, Tim Ansell (dont use), mithro
CC:
chromium-reviews
Visibility:
Public.

Description

Use chroot name instead of full path chroot command chroot name is desired for -c option instead of the full path chroot command BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=171145

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/install-chroot.sh View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
Wei James(wistoch)
8 years ago (2012-12-03 08:01:34 UTC) #1
Wei James(wistoch)
no response from tansell. +mmoss
8 years ago (2012-12-04 08:48:51 UTC) #2
Michael Moss
LGTM
8 years ago (2012-12-04 16:15:21 UTC) #3
Wei James(wistoch)
On 2012/12/04 16:15:21, Michael Moss wrote: > LGTM thanks!
8 years ago (2012-12-05 00:24:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/james.wei@intel.com/11418284/1
8 years ago (2012-12-05 00:26:20 UTC) #5
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
8 years ago (2012-12-05 00:29:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/james.wei@intel.com/11418284/1
8 years ago (2012-12-05 00:43:03 UTC) #7
commit-bot: I haz the power
Change committed as 171145
8 years ago (2012-12-05 03:35:58 UTC) #8
mithro
On 2012/12/04 08:48:51, Wei James(wistoch) wrote: > no response from tansell. > > +mmoss Sorry, ...
8 years ago (2012-12-05 04:27:38 UTC) #9
Wei James(wistoch)
On 2012/12/05 04:27:38, tansell wrote: > On 2012/12/04 08:48:51, Wei James(wistoch) wrote: > > no ...
8 years ago (2012-12-05 04:31:08 UTC) #10
Tim Ansell (dont use)
8 years ago (2012-12-05 23:22:31 UTC) #11
Ahh, looks like you where right.

I guess we should be checking the error code here?

Tim


On 5 December 2012 15:31, <james.wei@intel.com> wrote:

> On 2012/12/05 04:27:38, tansell wrote:
>
>> On 2012/12/04 08:48:51, Wei James(wistoch) wrote:
>> > no response from tansell.
>> >
>> > +mmoss
>>
>
>  Sorry, I've been in a course this week.
>>
>
>  What is this CL trying to fix? It breaks if /usr/local/bin isn't in
>> PATH...
>>
>
>  Tim
>>
>
> in this place, the name of the chroot required, it is not to execute the
> script.
>
>
>
> sudo schroot -c /usr/local/bin/"${target%bit}" -p -- apt-get clean
>
> if you run the above command, it will report "chroot not found".
>
>
>
>
https://chromiumcodereview.**appspot.com/11418284/<https://chromiumcodereview...
>

Powered by Google App Engine
This is Rietveld 408576698