Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issue 11418244: Order the GL overlays above windows if possible. (Closed)

Created:
8 years ago by Avi (use Gerrit)
Modified:
8 years ago
CC:
chromium-reviews, yusukes+watch_chromium.org, jam, penghuang+watch_chromium.org, sail+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, James Su
Visibility:
Public.

Description

Order the GL overlays above windows if possible. BUG=161603 TEST=bubbles have shadows Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170506

Patch Set 1 #

Patch Set 2 : missed a class #

Total comments: 2

Patch Set 3 : enum #

Patch Set 4 : oops, null check #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -17 lines) Patch
M chrome/browser/ui/cocoa/tab_contents/tab_contents_controller.mm View 2 chunks +4 lines, -0 lines 0 comments Download
M content/browser/renderer_host/compositing_iosurface_mac.h View 1 2 1 chunk +11 lines, -2 lines 0 comments Download
M content/browser/renderer_host/compositing_iosurface_mac.mm View 1 2 2 chunks +9 lines, -5 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.h View 2 chunks +4 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 1 2 4 chunks +19 lines, -9 lines 0 comments Download
M content/browser/web_contents/web_contents_view_guest.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_view_guest.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_view_mac.h View 2 chunks +4 lines, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_view_mac.mm View 1 2 3 3 chunks +14 lines, -1 line 0 comments Download
M content/public/browser/web_contents_view.h View 1 chunk +10 lines, -0 lines 0 comments Download
M content/test/test_web_contents_view.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M content/test/test_web_contents_view.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Avi (use Gerrit)
Kenneth: The compositing stuff. Nico: Mac stuff in general John: Content API. Re that API, ...
8 years ago (2012-11-29 20:40:22 UTC) #1
jam
lgtm
8 years ago (2012-11-29 21:58:30 UTC) #2
Ken Russell (switch to Gerrit)
lgtm
8 years ago (2012-11-29 22:17:27 UTC) #3
Nico
lgtm https://codereview.chromium.org/11418244/diff/6001/content/browser/renderer_host/compositing_iosurface_mac.h File content/browser/renderer_host/compositing_iosurface_mac.h (right): https://codereview.chromium.org/11418244/diff/6001/content/browser/renderer_host/compositing_iosurface_mac.h#newcode37 content/browser/renderer_host/compositing_iosurface_mac.h:37: static CompositingIOSurfaceMac* Create(bool below_window); nit: enum parameters read ...
8 years ago (2012-11-29 22:23:13 UTC) #4
Avi (use Gerrit)
https://codereview.chromium.org/11418244/diff/6001/content/browser/renderer_host/compositing_iosurface_mac.h File content/browser/renderer_host/compositing_iosurface_mac.h (right): https://codereview.chromium.org/11418244/diff/6001/content/browser/renderer_host/compositing_iosurface_mac.h#newcode37 content/browser/renderer_host/compositing_iosurface_mac.h:37: static CompositingIOSurfaceMac* Create(bool below_window); On 2012/11/29 22:23:13, Nico wrote: ...
8 years ago (2012-11-30 04:06:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/11418244/7013
8 years ago (2012-11-30 04:06:22 UTC) #6
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) unit_tests
8 years ago (2012-11-30 05:40:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/11418244/9004
8 years ago (2012-11-30 15:39:45 UTC) #8
commit-bot: I haz the power
8 years ago (2012-11-30 19:21:18 UTC) #9
Message was sent while issue was closed.
Change committed as 170506

Powered by Google App Engine
This is Rietveld 408576698