Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 11418237: Get DMP to run without HEAP_PROFILE_MMAP=1 (Closed)

Created:
8 years ago by greggman
Modified:
8 years ago
CC:
chromium-reviews, dmikurube+memory_chromium.org
Visibility:
Public.

Description

Get DMP to run without HEAP_PROFILE_MMAP=1 This is a step to getting DMP running in Windows. BUG=159993 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170417

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -17 lines) Patch
M third_party/tcmalloc/chromium/src/deep-heap-profile.cc View 2 chunks +22 lines, -17 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
greggman
These 2 changes seem to let DMP run without HEAP_PROFILE_MMAP=1. This also seems to get ...
8 years ago (2012-11-29 10:11:14 UTC) #1
Dai Mikurube (NOT FULLTIME)
LGTM. Thanks!
8 years ago (2012-11-30 03:38:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gman@chromium.org/11418237/1
8 years ago (2012-11-30 04:23:55 UTC) #3
commit-bot: I haz the power
8 years ago (2012-11-30 07:28:33 UTC) #4
Message was sent while issue was closed.
Change committed as 170417

Powered by Google App Engine
This is Rietveld 408576698