Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 11418235: Add perf tests based on json representation of layer tree (Closed)

Created:
8 years ago by jamesr
Modified:
8 years ago
Reviewers:
danakj, enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org, jscholler
Visibility:
Public.

Description

Add perf tests based on json representation of layer tree This extends cc_perftests to run perf tests based on a json dump of a layer tree with minimal code changes and adds a tree representing a tab switch UI with two stacks of 10 layers each. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170411

Patch Set 1 #

Patch Set 2 : update output to style expected by perf harness #

Total comments: 7

Patch Set 3 : address feedback, switch to runs/second over 1 second #

Patch Set 4 : make it work on android #

Patch Set 5 : Go up to 2 seconds per test, do correct math #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8489 lines, -15 lines) Patch
M build/android/run_tests.py View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M cc/cc_tests.gyp View 1 2 3 1 chunk +16 lines, -0 lines 0 comments Download
M cc/layer_tree_host_perftest.cc View 1 2 3 4 6 chunks +143 lines, -15 lines 0 comments Download
A cc/test/data/10_10_layer_tree.json View 1 chunk +8329 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
jamesr
This isn't fully clean yet, but it's darn handy. I generated the JSON by dumping ...
8 years ago (2012-11-29 08:36:02 UTC) #1
jamesr
I think this is good enough for a first cut. Can you do a review, ...
8 years ago (2012-11-30 00:12:04 UTC) #2
danakj
LGTM with some minor comments https://codereview.chromium.org/11418235/diff/3001/cc/layer_tree_host_perftest.cc File cc/layer_tree_host_perftest.cc (right): https://codereview.chromium.org/11418235/diff/3001/cc/layer_tree_host_perftest.cc#newcode38 cc/layer_tree_host_perftest.cc:38: impl->setNeedsRedraw(); Probly won't matter, ...
8 years ago (2012-11-30 01:21:00 UTC) #3
danakj
LGTM still
8 years ago (2012-11-30 01:53:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/11418235/11001
8 years ago (2012-11-30 02:07:59 UTC) #5
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
8 years ago (2012-11-30 03:34:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/11418235/11001
8 years ago (2012-11-30 04:43:48 UTC) #7
commit-bot: I haz the power
8 years ago (2012-11-30 05:51:47 UTC) #8
Message was sent while issue was closed.
Change committed as 170411

Powered by Google App Engine
This is Rietveld 408576698