Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Unified Diff: skia/ext/vector_canvas_unittest.cc

Issue 11418217: Add skia::RefPtr class to wrap ref counted classes from Skia. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: nit+rebase Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « skia/ext/vector_canvas.cc ('k') | skia/ext/vector_platform_device_emf_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: skia/ext/vector_canvas_unittest.cc
diff --git a/skia/ext/vector_canvas_unittest.cc b/skia/ext/vector_canvas_unittest.cc
index 8efbcdb1f6132fdf7f5b2be2b4367f5cda22430e..9f286457f62db5317e2bb49766e28e17302f11cd 100644
--- a/skia/ext/vector_canvas_unittest.cc
+++ b/skia/ext/vector_canvas_unittest.cc
@@ -390,8 +390,9 @@ class VectorCanvasTest : public ImageTest {
size_ = size;
context_ = new Context();
bitmap_ = new Bitmap(*context_, size_, size_);
- vcanvas_ = new VectorCanvas(VectorPlatformDeviceEmf::CreateDevice(
- size_, size_, true, context_->context()));
+ vcanvas_ = new VectorCanvas(
+ VectorPlatformDeviceEmf::CreateDevice(
+ size_, size_, true, context_->context()));
pcanvas_ = CreatePlatformCanvas(size_, size_, false);
// Clear white.
@@ -729,9 +730,9 @@ TEST_F(VectorCanvasTest, MAYBE_PathEffects) {
{
SkPaint paint;
SkScalar intervals[] = { 1, 1 };
- SkPathEffect* effect = new SkDashPathEffect(intervals, arraysize(intervals),
- 0);
- paint.setPathEffect(effect)->unref();
+ skia::RefPtr<SkPathEffect> effect = skia::AdoptRef(
+ new SkDashPathEffect(intervals, arraysize(intervals), 0));
+ paint.setPathEffect(effect.get());
paint.setColor(SK_ColorMAGENTA);
paint.setStyle(SkPaint::kStroke_Style);
@@ -749,9 +750,9 @@ TEST_F(VectorCanvasTest, MAYBE_PathEffects) {
{
SkPaint paint;
SkScalar intervals[] = { 3, 5 };
- SkPathEffect* effect = new SkDashPathEffect(intervals, arraysize(intervals),
- 0);
- paint.setPathEffect(effect)->unref();
+ skia::RefPtr<SkPathEffect> effect = skia::AdoptRef(
+ new SkDashPathEffect(intervals, arraysize(intervals), 0));
+ paint.setPathEffect(effect.get());
paint.setColor(SK_ColorMAGENTA);
paint.setStyle(SkPaint::kStroke_Style);
@@ -767,9 +768,9 @@ TEST_F(VectorCanvasTest, MAYBE_PathEffects) {
{
SkPaint paint;
SkScalar intervals[] = { 2, 1 };
- SkPathEffect* effect = new SkDashPathEffect(intervals, arraysize(intervals),
- 0);
- paint.setPathEffect(effect)->unref();
+ skia::RefPtr<SkPathEffect> effect = skia::AdoptRef(
+ new SkDashPathEffect(intervals, arraysize(intervals), 0));
+ paint.setPathEffect(effect.get());
paint.setColor(SK_ColorMAGENTA);
paint.setStyle(SkPaint::kStroke_Style);
@@ -783,9 +784,9 @@ TEST_F(VectorCanvasTest, MAYBE_PathEffects) {
{
SkPaint paint;
SkScalar intervals[] = { 1, 1 };
- SkPathEffect* effect = new SkDashPathEffect(intervals, arraysize(intervals),
- 0);
- paint.setPathEffect(effect)->unref();
+ skia::RefPtr<SkPathEffect> effect = skia::AdoptRef(
+ new SkDashPathEffect(intervals, arraysize(intervals), 0));
+ paint.setPathEffect(effect.get());
paint.setColor(SK_ColorMAGENTA);
paint.setStyle(SkPaint::kStroke_Style);
« no previous file with comments | « skia/ext/vector_canvas.cc ('k') | skia/ext/vector_platform_device_emf_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698