chrome/renderer/print_web_view_helper_mac.mm - Issue 11418217: Add skia::RefPtr class to wrap ref counted classes from Skia.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/print_web_view_helper_mac.mm

Issue 11418217: Add skia::RefPtr class to wrap ref counted classes from Skia. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: nit+rebase Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/print_web_view_helper_mac.mm

diff --git a/chrome/renderer/print_web_view_helper_mac.mm b/chrome/renderer/print_web_view_helper_mac.mm

index e74739bd4add963e97ac7f496f7771ddbfbb6a08..378e89ce9ca1a93bbc869919ceae5ba839468ff2 100644

--- a/chrome/renderer/print_web_view_helper_mac.mm

+++ b/chrome/renderer/print_web_view_helper_mac.mm

@@ -122,8 +122,8 @@ void PrintWebViewHelper::RenderPage(

if (!device)

return;

- SkRefPtr<skia::VectorCanvas> canvas = new skia::VectorCanvas(device);

- canvas->unref(); // SkRefPtr and new both took a reference.

+ skia::RefPtr<skia::VectorCanvas> canvas =

+ skia::AdoptRef(new skia::VectorCanvas(device));

WebKit::WebCanvas* canvas_ptr = canvas.get();

printing::MetafileSkiaWrapper::SetMetafileOnCanvas(*canvas, metafile);

skia::SetIsDraftMode(*canvas, is_print_ready_metafile_sent_);