Issue 11418196: Fix example_browser_main_parts build failure on win/linux aura

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11418196: Fix example_browser_main_parts build failure on win/linux aura (Closed)

Created:
8 years ago by oshima

Modified:
8 years ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix example_browser_main_parts build failure on win/linux aura. Add views_examples_with_content_exe to the aura_builder target so that it will be build by bots. This compiles on chromeos, but doesn't work. I will fix this separately. BUG=162962 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=169954

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : chromeos build fix #

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -3 lines)			Patch
	M	build/all.gyp	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
	M	ui/views/examples/content_client/examples_browser_main_parts.cc	View	1 2	2 chunks	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/11418196/8001

8 years ago (2012-11-28 00:55:44 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/11418196/8001

8 years ago (2012-11-28 15:12:52 UTC) #4

Message was sent while issue was closed.

Change committed as 169954

Expand Messages | Collapse Messages