Don't call settings.GetIsGerrit() before parser.parse_args()

Don't call settings.GetIsGerrit() before parser.parse_args()

settings.GetIsGerrit() would invoke logging.basicConfig() and
preemtps the basicConfig for verbose option in parser.parse_args.

R=maruel@chromium.org,ilevy@chromium.org
BUG=162600
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=169843

[Isaac (away), 2012-11-27 08:35:09]

Minor suggestion below.

Could we default to the branch from GetRemoteBranch() instead of origin/master?

https://chromiumcodereview.appspot.com/11418171/diff/1/git_cl.py
File git_cl.py (right):

https://chromiumcodereview.appspot.com/11418171/diff/1/git_cl.py#newcode1250
git_cl.py:1250: help='target branch to upload. ' +
This help message is a bit confusing, let's clarify.  Also some spacing / style
nits.  How about:

help=('When uploading to gerrit, remote branch to '
      'use for CL.  Default: master')

[ukai, 2012-11-27 08:54:02]

https://chromiumcodereview.appspot.com/11418171/diff/1/git_cl.py
File git_cl.py (right):

https://chromiumcodereview.appspot.com/11418171/diff/1/git_cl.py#newcode1250
git_cl.py:1250: help='target branch to upload. ' +
On 2012/11/27 08:35:09, Isaac wrote:
> This help message is a bit confusing, let's clarify.  Also some spacing /
style
> nits.  How about:
> 
> help=('When uploading to gerrit, remote branch to '
>       'use for CL.  Default: master')

Done.

[M-A Ruel, 2012-11-27 14:20:51]

https://codereview.chromium.org/11418171/diff/3002/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/11418171/diff/3002/git_cl.py#newcode1250
git_cl.py:1250: help='When uploading to gerrit, remote branch to ' +
Also no need for + and align the second line at the "=".

https://codereview.chromium.org/11418171/diff/3002/git_cl.py#newcode1256
git_cl.py:1256: print >> sys.stderr, (
Use parser.error() instead

[ukai, 2012-11-28 02:25:19]

https://chromiumcodereview.appspot.com/11418171/diff/3002/git_cl.py
File git_cl.py (right):

https://chromiumcodereview.appspot.com/11418171/diff/3002/git_cl.py#newcode1250
git_cl.py:1250: help='When uploading to gerrit, remote branch to ' +
On 2012/11/27 14:20:52, Marc-Antoine Ruel wrote:
> Also no need for + and align the second line at the "=".

Done.

https://chromiumcodereview.appspot.com/11418171/diff/3002/git_cl.py#newcode1256
git_cl.py:1256: print >> sys.stderr, (
On 2012/11/27 14:20:52, Marc-Antoine Ruel wrote:
> Use parser.error() instead

Done.

[M-A Ruel, 2012-11-28 02:32:58]

lgtm

https://chromiumcodereview.appspot.com/11418171/diff/7001/git_cl.py
File git_cl.py (right):

https://chromiumcodereview.appspot.com/11418171/diff/7001/git_cl.py#newcode1256
git_cl.py:1256: parser.error('WARNING: Use --target_branch for non gerrit
repository.')
it'll already be prefixed with error: so it's kinda confusing. Remove the
WARNING.

[ukai, 2012-11-28 02:36:22]

https://chromiumcodereview.appspot.com/11418171/diff/7001/git_cl.py
File git_cl.py (right):

https://chromiumcodereview.appspot.com/11418171/diff/7001/git_cl.py#newcode1256
git_cl.py:1256: parser.error('WARNING: Use --target_branch for non gerrit
repository.')
On 2012/11/28 02:32:59, Marc-Antoine Ruel wrote:
> it'll already be prefixed with error: so it's kinda confusing. Remove the
> WARNING.

Done.

[commit-bot: I haz the power, 2012-11-28 04:22:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ukai@chromium.org/11418171/1004

[commit-bot: I haz the power, 2012-11-28 04:24:54]

Change committed as 169843