Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 11418138: Fix valgrind warnings. (Closed)

Created:
8 years, 1 month ago by Yang
Modified:
8 years ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Fix valgrind warnings. BUG= Committed: https://code.google.com/p/v8/source/detail?r=13050

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -6 lines) Patch
M src/compiler.h View 1 chunk +2 lines, -0 lines 1 comment Download
M src/optimizing-compiler-thread.h View 3 chunks +8 lines, -5 lines 1 comment Download
M src/optimizing-compiler-thread.cc View 1 chunk +2 lines, -1 line 1 comment Download

Messages

Total messages: 3 (0 generated)
Yang
Explanations inline. https://codereview.chromium.org/11418138/diff/1/src/compiler.h File src/compiler.h (right): https://codereview.chromium.org/11418138/diff/1/src/compiler.h#newcode296 src/compiler.h:296: INLINE(void* operator new(size_t size)) { return Malloced::New(size); ...
8 years, 1 month ago (2012-11-23 15:46:20 UTC) #1
Yang
8 years, 1 month ago (2012-11-23 15:46:40 UTC) #2
Jakob Kummerow
8 years ago (2012-11-23 20:33:04 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698