Add a test for SymbolMappingCache in tools/deep_memory_profiler/dmprof.py.

Add a test for SymbolMappingCache in tools/deep_memory_profiler/dmprof.py.

    
BUG=123749
NOTRY=true


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=169564

[Dai Mikurube (NOT FULLTIME), 2012-11-26 07:11:17]

Hi,

Could you take a look when you have time?  It adds a test for SymbolMappingCache
(f.k.a. SymbolCache) with some refactoring of dmprof.py.

[jochen (gone - plz use gerrit), 2012-11-26 09:31:52]

the CL is quite involved, maybe it was easier to review if you first added the
test, and then do the refactoring?

https://codereview.chromium.org/11418130/diff/2001/tools/deep_memory_profiler...
File tools/deep_memory_profiler/tests/dmprof_test.py (right):

https://codereview.chromium.org/11418130/diff/2001/tools/deep_memory_profiler...
tools/deep_memory_profiler/tests/dmprof_test.py:35: _TEST_FUNCTION_CACHE = """1
0x0000000000000001
what about using textwrap.dedent for multi-line constants?

[Dai Mikurube (NOT FULLTIME), 2012-11-26 09:41:45]

Thanks.

Actually, this refactoring is to make SymbolMappingCache testable (especially
for SymbolFinder).

The previous version was hard to test since it depends on many other classes and
files.

https://codereview.chromium.org/11418130/diff/2001/tools/deep_memory_profiler...
File tools/deep_memory_profiler/tests/dmprof_test.py (right):

https://codereview.chromium.org/11418130/diff/2001/tools/deep_memory_profiler...
tools/deep_memory_profiler/tests/dmprof_test.py:35: _TEST_FUNCTION_CACHE = """1
0x0000000000000001
On 2012/11/26 09:31:52, jochen wrote:
> what about using textwrap.dedent for multi-line constants?

Thanks for the good idea.  Done.

[Dai Mikurube (NOT FULLTIME), 2012-11-26 09:46:12]

Patch Set 4 uses textwrap.dedent in PolicyTest.

[M-A Ruel, 2012-11-26 15:43:50]

lgtm

https://codereview.chromium.org/11418130/diff/1002/tools/deep_memory_profiler...
File tools/deep_memory_profiler/dmprof.py (right):

https://codereview.chromium.org/11418130/diff/1002/tools/deep_memory_profiler...
tools/deep_memory_profiler/dmprof.py:187: _FIND_RUNTIME_SYMBOLS_FUNCTIONS = {
good idea

https://codereview.chromium.org/11418130/diff/1002/tools/deep_memory_profiler...
tools/deep_memory_profiler/dmprof.py:232: cache_f.seek(0, 0)
Please use os.SEEK_SET instead

https://codereview.chromium.org/11418130/diff/1002/tools/deep_memory_profiler...
tools/deep_memory_profiler/dmprof.py:243: cache_f.seek(0, 2)
Please use os.SEEK_END instead

[Dai Mikurube (NOT FULLTIME), 2012-11-27 02:53:37]

Thanks!  I'll be committing.

https://codereview.chromium.org/11418130/diff/1002/tools/deep_memory_profiler...
File tools/deep_memory_profiler/dmprof.py (right):

https://codereview.chromium.org/11418130/diff/1002/tools/deep_memory_profiler...
tools/deep_memory_profiler/dmprof.py:187: _FIND_RUNTIME_SYMBOLS_FUNCTIONS = {
On 2012/11/26 15:43:51, Marc-Antoine Ruel wrote:
> good idea

thanks :)

https://codereview.chromium.org/11418130/diff/1002/tools/deep_memory_profiler...
tools/deep_memory_profiler/dmprof.py:232: cache_f.seek(0, 0)
On 2012/11/26 15:43:51, Marc-Antoine Ruel wrote:
> Please use os.SEEK_SET instead

Done.

https://codereview.chromium.org/11418130/diff/1002/tools/deep_memory_profiler...
tools/deep_memory_profiler/dmprof.py:243: cache_f.seek(0, 2)
On 2012/11/26 15:43:51, Marc-Antoine Ruel wrote:
> Please use os.SEEK_END instead

Done.

[commit-bot: I haz the power, 2012-11-27 02:54:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dmikurube@chromium.org/11418130/5004

[commit-bot: I haz the power, 2012-11-27 03:07:09]

Change committed as 169564