Matching IBM Java plugin using pattern matching.

Changing plugin matching to pattern matching.

Substring matching for Java confuses IBM Java and Oracle Java. Matching changed to use pattern for all plugins.

New entry added for IBM Java in plugins_win.json with pattern "*IBM*java*". For Oracle Java the pattern is "Java*"

BUG=148948
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=169383

[ibraa, 2012-11-22 18:36:49]

Please Review.

[Bernhard Bauer, 2012-11-22 18:40:47]

https://codereview.chromium.org/11418129/diff/4001/chrome/browser/plugins/plu...
File chrome/browser/plugins/plugin_metadata.cc (right):

https://codereview.chromium.org/11418129/diff/4001/chrome/browser/plugins/plu...
chrome/browser/plugins/plugin_metadata.cc:75: return use_pattern_matching_ ?
Hm, we might be able to keep this a bit simpler by always using MatchPattern. We
just need to transform the patterns where we want to do substring matching by
pre- and appending a "*".

[ibraa, 2012-11-22 19:46:30]

https://codereview.chromium.org/11418129/diff/7010/chrome/browser/resources/p...
File chrome/browser/resources/plugin_metadata/plugins_linux.json (right):

https://codereview.chromium.org/11418129/diff/7010/chrome/browser/resources/p...
chrome/browser/resources/plugin_metadata/plugins_linux.json:70:
"group_name_matcher": "Java(TM)*"
Plugin name for Oracle Java on linux is Java(TM), the pattern is different here
because matching "*Java*" only will match both Oracle and IBM Java.

I assume the name is the same for other platforms, isn't it?

[Bernhard Bauer, 2012-11-22 20:08:04]

We will run into issues when pushing the updated metadata files online, because
there will still be old clients :-/ We might need to fetch the new files from a
new URL.

https://codereview.chromium.org/11418129/diff/7010/chrome/browser/resources/p...
File chrome/browser/resources/plugin_metadata/plugins_linux.json (right):

https://codereview.chromium.org/11418129/diff/7010/chrome/browser/resources/p...
chrome/browser/resources/plugin_metadata/plugins_linux.json:70:
"group_name_matcher": "Java(TM)*"
On 2012/11/22 19:46:30, ibra wrote:
> Plugin name for Oracle Java on linux is Java(TM), the pattern is different
here
> because matching "*Java*" only will match both Oracle and IBM Java.
> 
> I assume the name is the same for other platforms, isn't it?

I'm not completely sure; in general Java has very weird naming schemes :-/

OTOH, maybe matching "Java" at the beginning of the name is already sufficient?

[ibraa, 2012-11-23 00:58:28]

"We will run into issues when pushing the updated metadata files online, because
there will still be old clients :-/ We might need to fetch the new files from a
new URL."

That is the reason I used "use_pattern_matching" :)

https://codereview.chromium.org/11418129/diff/7010/chrome/browser/resources/p...
File chrome/browser/resources/plugin_metadata/plugins_linux.json (right):

https://codereview.chromium.org/11418129/diff/7010/chrome/browser/resources/p...
chrome/browser/resources/plugin_metadata/plugins_linux.json:70:
"group_name_matcher": "Java(TM)*"
I guess so, Done.
On 2012/11/22 20:08:04, Bernhard Bauer wrote:
> On 2012/11/22 19:46:30, ibra wrote:
> > Plugin name for Oracle Java on linux is Java(TM), the pattern is different
> here
> > because matching "*Java*" only will match both Oracle and IBM Java.
> > 
> > I assume the name is the same for other platforms, isn't it?
> 
> I'm not completely sure; in general Java has very weird naming schemes :-/
> 
> OTOH, maybe matching "Java" at the beginning of the name is already
sufficient?

[ibraa, 2012-11-23 11:17:56]

Thanks for the running try-bot :). This is so helpful given my awesome machine
:D

On 2012/11/23 00:58:28, ibra wrote:
> "We will run into issues when pushing the updated metadata files online,
because
> there will still be old clients :-/ We might need to fetch the new files from
a
> new URL."
> 
> That is the reason I used "use_pattern_matching" :)
> 
>
https://codereview.chromium.org/11418129/diff/7010/chrome/browser/resources/p...
> File chrome/browser/resources/plugin_metadata/plugins_linux.json (right):
> 
>
https://codereview.chromium.org/11418129/diff/7010/chrome/browser/resources/p...
> chrome/browser/resources/plugin_metadata/plugins_linux.json:70:
> "group_name_matcher": "Java(TM)*"
> I guess so, Done.
> On 2012/11/22 20:08:04, Bernhard Bauer wrote:
> > On 2012/11/22 19:46:30, ibra wrote:
> > > Plugin name for Oracle Java on linux is Java(TM), the pattern is different
> > here
> > > because matching "*Java*" only will match both Oracle and IBM Java.
> > > 
> > > I assume the name is the same for other platforms, isn't it?
> > 
> > I'm not completely sure; in general Java has very weird naming schemes :-/
> > 
> > OTOH, maybe matching "Java" at the beginning of the name is already
> sufficient?

[Bernhard Bauer, 2012-11-23 12:51:13]

https://codereview.chromium.org/11418129/diff/5011/chrome/browser/web_resourc...
File chrome/browser/web_resource/plugins_resource_service.cc (right):

https://codereview.chromium.org/11418129/diff/5011/chrome/browser/web_resourc...
chrome/browser/web_resource/plugins_resource_service.cc:24:
"https://www.gstatic.com/chrome/config/plugins_pattern_matching/";
Can we name this plugins_2 or something? Then we can use plugins_n for other
compat-breaking changes in the future.

[ibraa, 2012-11-23 12:58:22]

https://codereview.chromium.org/11418129/diff/5011/chrome/browser/web_resourc...
File chrome/browser/web_resource/plugins_resource_service.cc (right):

https://codereview.chromium.org/11418129/diff/5011/chrome/browser/web_resourc...
chrome/browser/web_resource/plugins_resource_service.cc:24:
"https://www.gstatic.com/chrome/config/plugins_pattern_matching/";
On 2012/11/23 12:51:13, Bernhard Bauer wrote:
> Can we name this plugins_2 or something? Then we can use plugins_n for other
> compat-breaking changes in the future.

Done.

[Bernhard Bauer, 2012-11-23 13:02:54]

LGTM!

I'll update the files server-side.

[ibraa, 2012-11-23 13:32:03]

I won't commit until server-side is updated. Let me know when you are done. Note
it will take the new files 2 hours to be live after you commit your CL.

On 2012/11/23 13:02:54, Bernhard Bauer wrote:
> LGTM!
> 
> I'll update the files server-side.

[Bernhard Bauer, 2012-11-23 14:19:28]

On 2012/11/23 13:32:03, ibra wrote:
> I won't commit until server-side is updated. Let me know when you are done.
Note
> it will take the new files 2 hours to be live after you commit your CL.

Hm. There won't be any client using this until the next Canary release. And even
then, if the request fails, I think nothing should happen?

> On 2012/11/23 13:02:54, Bernhard Bauer wrote:
> > LGTM!
> > 
> > I'll update the files server-side.

[commit-bot: I haz the power, 2012-11-23 20:11:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ibraaaa@gmail.com/11418129/5013

[commit-bot: I haz the power, 2012-11-23 20:11:49]

Presubmit check for 11418129-5013 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome/browser/web_resource

Presubmit checks took 1.0s to calculate.

[ibraa, 2012-11-23 23:03:05]

Hi Dan,

Can I have an OWNERS review for chrome/browser/web_resource/?

Thanks!

[Dan Beam, 2012-11-23 23:50:58]

lgtm

[commit-bot: I haz the power, 2012-11-24 06:23:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ibraaaa@gmail.com/11418129/5013

[commit-bot: I haz the power, 2012-11-24 08:38:17]

Change committed as 169383