Build minidump_stackwalk and minidump_dump on all supported platforms.

Build minidump_stackwalk and minidump_dump on all supported platforms.

Previously, these would only be built on Linux and Android with
linux_breakpad==1. These can be built now on Mac.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=169148

[Mark Mentovai, 2012-11-21 20:27:53]

https://codereview.chromium.org/11418122/diff/1/breakpad/breakpad.gyp
File breakpad/breakpad.gyp (right):

https://codereview.chromium.org/11418122/diff/1/breakpad/breakpad.gyp#newcode19
breakpad/breakpad.gyp:19: 'include_dirs': [
Why not move this into the gypi too?

https://codereview.chromium.org/11418122/diff/1/breakpad/breakpad_tools.gypi
File breakpad/breakpad_tools.gypi (right):

https://codereview.chromium.org/11418122/diff/1/breakpad/breakpad_tools.gypi#...
breakpad/breakpad_tools.gypi:28: 'xcode_settings': {
Move me inside the clang==1 section

(even though it’s unlikely that we’ll do Mac builds without clang. It’s just to
keep the -W flag with the other instance of itself, which is a little nicer in
case someone adds another condition to the end of the list in the future.)

[Robert Sesek, 2012-11-21 20:30:58]

https://codereview.chromium.org/11418122/diff/1/breakpad/breakpad.gyp
File breakpad/breakpad.gyp (right):

https://codereview.chromium.org/11418122/diff/1/breakpad/breakpad.gyp#newcode19
breakpad/breakpad.gyp:19: 'include_dirs': [
On 2012/11/21 20:27:54, Mark Mentovai wrote:
> Why not move this into the gypi too?

Done.

https://codereview.chromium.org/11418122/diff/1/breakpad/breakpad_tools.gypi
File breakpad/breakpad_tools.gypi (right):

https://codereview.chromium.org/11418122/diff/1/breakpad/breakpad_tools.gypi#...
breakpad/breakpad_tools.gypi:28: 'xcode_settings': {
On 2012/11/21 20:27:54, Mark Mentovai wrote:
> Move me inside the clang==1 section
> 
> (even though it’s unlikely that we’ll do Mac builds without clang. It’s just
to
> keep the -W flag with the other instance of itself, which is a little nicer in
> case someone adds another condition to the end of the list in the future.)

Done.

[Mark Mentovai, 2012-11-21 20:31:31]

lgtmultip…

[commit-bot: I haz the power, 2012-11-21 20:31:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rsesek@chromium.org/11418122/6001

[commit-bot: I haz the power, 2012-11-21 20:53:44]

Sorry for I got bad news for ya.
Compile failed with a clobber build on win.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-11-21 20:59:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rsesek@chromium.org/11418122/6005

[commit-bot: I haz the power, 2012-11-21 22:44:05]

Change committed as 169148