Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(39)

Issue 11418079: Do not compile third_party/libva on Linux. It's not used. (Closed)

Created:
6 years, 3 months ago by Paweł Hajdan Jr.
Modified:
5 years, 3 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Do not compile third_party/libva on Linux. It's not used. This is also helpful for Linux distros, by removing one bundled library from their list. BUG=137247 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=168898

Patch Set 1 #

Patch Set 2 : fix build #

Patch Set 3 : uploading again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M content/content_common.gypi View 1 1 chunk +1 line, -1 line 0 comments Download
M content/content_tests.gypi View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
Paweł Hajdan Jr.
6 years, 3 months ago (2012-11-20 01:35:55 UTC) #1
piman
LGTM, AFAIK it's only used for debugging currently, but don't be surprised if someone puts ...
6 years, 3 months ago (2012-11-20 01:38:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/phajdan.jr@chromium.org/11418079/1
6 years, 3 months ago (2012-11-20 01:41:12 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
6 years, 3 months ago (2012-11-20 02:14:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/phajdan.jr@chromium.org/11418079/3005
6 years, 3 months ago (2012-11-20 18:29:30 UTC) #5
commit-bot: I haz the power
Retried try job too often for step(s) browser_tests
6 years, 3 months ago (2012-11-20 20:59:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/phajdan.jr@chromium.org/11418079/3005
6 years, 3 months ago (2012-11-20 21:36:33 UTC) #7
commit-bot: I haz the power
Change committed as 168898
6 years, 3 months ago (2012-11-20 22:45:18 UTC) #8
super.varvara1977
5 years, 3 months ago (2013-11-11 23:45:30 UTC) #9
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698