Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(716)

Unified Diff: chrome/browser/chromeos/login/user_manager_impl.cc

Issue 11418048: Add copy and assignment to FundamentalValue and StringValue. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/user_manager_impl.cc
diff --git a/chrome/browser/chromeos/login/user_manager_impl.cc b/chrome/browser/chromeos/login/user_manager_impl.cc
index d62901adc8f9dda1c6ea494fb5c9fe97d7d673e5..fb3c3dab24578922c9fbc5bcbef822e0f405a50d 100644
--- a/chrome/browser/chromeos/login/user_manager_impl.cc
+++ b/chrome/browser/chromeos/login/user_manager_impl.cc
@@ -174,13 +174,13 @@ void UserManagerImpl::UserLoggedIn(const std::string& email,
prefs_users_update->Clear();
// Make sure this user is first.
- prefs_users_update->Append(Value::CreateStringValue(email));
+ prefs_users_update->Append(new base::StringValue(email));
UserList::iterator logged_in_user = users_.end();
for (UserList::iterator it = users_.begin(); it != users_.end(); ++it) {
std::string user_email = (*it)->email();
// Skip the most recent user.
if (email != user_email)
- prefs_users_update->Append(Value::CreateStringValue(user_email));
+ prefs_users_update->Append(new base::StringValue(user_email));
else
logged_in_user = it;
}
@@ -369,7 +369,7 @@ void UserManagerImpl::SaveUserDisplayName(const std::string& username,
DictionaryPrefUpdate display_name_update(local_state, kUserDisplayName);
display_name_update->SetWithoutPathExpansion(
username,
- base::Value::CreateStringValue(display_name));
+ new base::StringValue(display_name));
}
string16 UserManagerImpl::GetUserDisplayName(
@@ -397,7 +397,7 @@ void UserManagerImpl::SaveUserDisplayEmail(const std::string& username,
DictionaryPrefUpdate display_email_update(local_state, kUserDisplayEmail);
display_email_update->SetWithoutPathExpansion(
username,
- base::Value::CreateStringValue(display_email));
+ new base::StringValue(display_email));
}
std::string UserManagerImpl::GetUserDisplayEmail(
@@ -691,7 +691,7 @@ void UserManagerImpl::RemoveUserFromListInternal(const std::string& email) {
std::string user_email = (*it)->email();
// Skip user that we would like to delete.
if (email != user_email)
- prefs_users_update->Append(Value::CreateStringValue(user_email));
+ prefs_users_update->Append(new base::StringValue(user_email));
else
user_to_remove = it;
}

Powered by Google App Engine
This is Rietveld 408576698