Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 11418015: Plug IOSurface leak at context tear-down. (Closed)

Created:
8 years, 1 month ago by ccameron
Modified:
8 years, 1 month ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium, sail+watch_chromium.org
Visibility:
Public.

Description

Plug IOSurface leak at context tear-down. Change the ordering of the destruction of a command buffer's surface and context, so that the context is current while the surface is destroyed. Add lots of asserts to the surface tear-down path to verify that we have the context that we need in order to delete the resources. If we don't delete the FBO and texture, then they will hold a reference to the IOSurface until the share group is destroyed, which, in the case of tabs opened from Gmail, may be a very long time in the future. BUG=158469 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=168151

Patch Set 1 #

Patch Set 2 : Remove unrelated patch #

Patch Set 3 : Change CHECK to DCHECK #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -11 lines) Patch
M content/common/gpu/gpu_command_buffer_stub.cc View 1 chunk +8 lines, -1 line 0 comments Download
M content/common/gpu/image_transport_surface_mac.cc View 1 2 2 chunks +8 lines, -10 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ccameron
This plugs the last of the IOSurface leaks. With this and the other patch checked ...
8 years, 1 month ago (2012-11-15 23:36:43 UTC) #1
Ken Russell (switch to Gerrit)
LGTM. Thank you for tracking this down. I think you should request that this be ...
8 years, 1 month ago (2012-11-16 02:33:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ccameron@chromium.org/11418015/4001
8 years, 1 month ago (2012-11-16 03:04:40 UTC) #3
commit-bot: I haz the power
8 years, 1 month ago (2012-11-16 07:36:07 UTC) #4
Change committed as 168151

Powered by Google App Engine
This is Rietveld 408576698