Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Issue 11418003: Remove rc file for scaled resource pak (Closed)

Created:
8 years, 1 month ago by oshima
Modified:
8 years, 1 month ago
Reviewers:
sail
CC:
chromium-reviews, darin-cc_chromium.org, apatrick_chromium
Visibility:
Public.

Description

Remove rc file for scaled resource pak. They're already repacked in chrome_<scale>_percent.pak TBR=sail@chromium.org BUG=160934 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=168125 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=168355

Patch Set 1 #

Patch Set 2 : keep webkit_resources for DumpRenderTree #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -20 lines) Patch
M chrome/chrome_dll.gypi View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 5 chunks +0 lines, -10 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/renderer/resources/renderer_resources.grd View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/gpu/test_support_gpu.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/gpu/test_support_gpu.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/content_tests.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download
M webkit/glue/resources/webkit_resources.grd View 1 1 chunk +3 lines, -0 lines 0 comments Download
M webkit/tools/test_shell/test_shell.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
oshima
8 years, 1 month ago (2012-11-15 09:58:57 UTC) #1
sail
lgtm
8 years, 1 month ago (2012-11-15 16:16:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/11418003/1
8 years, 1 month ago (2012-11-15 17:04:17 UTC) #3
commit-bot: I haz the power
Presubmit check for 11418003-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 1 month ago (2012-11-15 17:04:22 UTC) #4
oshima
On 2012/11/15 17:04:22, I haz the power (commit-bot) wrote: > Presubmit check for 11418003-1 failed ...
8 years, 1 month ago (2012-11-15 17:16:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/11418003/1
8 years, 1 month ago (2012-11-15 17:16:10 UTC) #6
commit-bot: I haz the power
Retried try job too often for step(s) sync_integration_tests
8 years, 1 month ago (2012-11-15 20:55:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/11418003/1
8 years, 1 month ago (2012-11-16 01:50:06 UTC) #8
commit-bot: I haz the power
Change committed as 168125
8 years, 1 month ago (2012-11-16 03:37:05 UTC) #9
kinuko
Hmm it looks it's causing compile error on Win bot? http://build.chromium.org/p/chromium/builders/Win/builds/13911/steps/compile/logs/stdio
8 years, 1 month ago (2012-11-16 07:08:16 UTC) #10
oshima
looks like webkit_resources.rc is linked in outside of chromium:(. please revert it. - oshima On ...
8 years, 1 month ago (2012-11-16 07:18:51 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/11418003/1009
8 years, 1 month ago (2012-11-16 19:06:01 UTC) #12
commit-bot: I haz the power
8 years, 1 month ago (2012-11-17 02:34:48 UTC) #13
Change committed as 168355

Powered by Google App Engine
This is Rietveld 408576698