Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 11417121: Undo all existing overscan settings before updating to a new overscan settings (2nd) (Closed)

Created:
8 years, 1 month ago by Jun Mukai
Modified:
8 years ago
Reviewers:
Daniel Erat, oshima
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Undo all existing overscan settings before updating to a new overscan settings (2nd) This is 2nd patch of crrev.com/168974, which was reverted due to win_aura test failure. I noticed that this is essentially a bug of win-aura, so I disabled the broken test for windows temporarily. Original description: If an existing display has overscan setting and SetDisplayOverscan is called for a different display, the display manager will call OnNativeDisplayChanged(), and it will re-apply the overscan setting to other displays, so the effect could be twice or more. We need to undo the existing settings beforehand. BUG=161097 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170013

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : just for check #

Patch Set 5 : another check #

Patch Set 6 : check log #

Patch Set 7 : check log 2 #

Patch Set 8 : call OnHostResized directly from root_window_host_win #

Patch Set 9 : #

Patch Set 10 : disbled the broken test #

Total comments: 2

Patch Set 11 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -42 lines) Patch
M ash/display/display_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/display/display_controller_unittest.cc View 1 2 3 4 5 6 7 8 9 2 chunks +6 lines, -2 lines 0 comments Download
M ash/display/display_manager.h View 3 chunks +18 lines, -5 lines 0 comments Download
M ash/display/display_manager.cc View 1 2 6 chunks +41 lines, -34 lines 0 comments Download
M ash/display/display_manager_unittest.cc View 2 chunks +17 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Jun Mukai
8 years ago (2012-11-28 00:10:06 UTC) #1
oshima
https://codereview.chromium.org/11417121/diff/14002/ui/aura/root_window_host_win.cc File ui/aura/root_window_host_win.cc (right): https://codereview.chromium.org/11417121/diff/14002/ui/aura/root_window_host_win.cc#newcode17 ui/aura/root_window_host_win.cc:17: #include "ui/gfx/screen.h" revert?
8 years ago (2012-11-28 00:27:21 UTC) #2
Jun Mukai
https://codereview.chromium.org/11417121/diff/14002/ui/aura/root_window_host_win.cc File ui/aura/root_window_host_win.cc (right): https://codereview.chromium.org/11417121/diff/14002/ui/aura/root_window_host_win.cc#newcode17 ui/aura/root_window_host_win.cc:17: #include "ui/gfx/screen.h" On 2012/11/28 00:27:21, oshima wrote: > revert? ...
8 years ago (2012-11-28 00:29:49 UTC) #3
oshima
lgtm
8 years ago (2012-11-28 00:36:56 UTC) #4
Jun Mukai
derat, could you review this? It doesn't change so much from the first patch (reverted ...
8 years ago (2012-11-28 17:06:26 UTC) #5
Daniel Erat
lgtm
8 years ago (2012-11-28 17:11:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/11417121/10002
8 years ago (2012-11-28 17:20:21 UTC) #7
commit-bot: I haz the power
8 years ago (2012-11-28 19:15:55 UTC) #8
Message was sent while issue was closed.
Change committed as 170013

Powered by Google App Engine
This is Rietveld 408576698