Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Issue 11417120: Setting Windows Text for App Launcher. (Closed)

Created:
8 years, 1 month ago by huangs
Modified:
8 years, 1 month ago
CC:
chromium-reviews, tfarina
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Setting Windows Text for App Launcher. In Windows 7+, if you change Taskbar Properties -> Taskbar buttons -> Never combine, then running the App Launcher would change the pinned shortcut into a long rectangle on the task bar. Without Windows Text, the rectangle would be mostly blank. So we set the Windows Text to IDS_APP_LIST_SHORTCUT_NAME. BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=169222

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/browser/ui/views/app_list/app_list_controller_win.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
huangs
Note that google_chrome_strings.grd currently sets IDS_APP_LIST_SHORTCUT_NAME as "Chrome Apps Launcher". Although we'll finalize on the ...
8 years, 1 month ago (2012-11-21 18:04:08 UTC) #1
erikwright (departed)
LGTM.
8 years, 1 month ago (2012-11-21 21:58:19 UTC) #2
benwells
lgtm BTW I have a vague memory of changing App -> Apps at some point ...
8 years, 1 month ago (2012-11-22 00:16:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/huangs@chromium.org/11417120/1
8 years, 1 month ago (2012-11-22 04:27:13 UTC) #4
commit-bot: I haz the power
8 years, 1 month ago (2012-11-22 06:31:19 UTC) #5
Change committed as 169222

Powered by Google App Engine
This is Rietveld 408576698