Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 11417111: cc: Add PictureLayerTilingSet to manage PictureLayerTiling (Closed)

Created:
8 years, 1 month ago by enne (OOO)
Modified:
8 years, 1 month ago
Reviewers:
nduca
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

cc: Add PictureLayerTilingSet to manage PictureLayerTiling PictureLayerTilingSet has multiple tilings at different content scales. This should abstract managing the tilings from PictureLayerImpl. The layer can then ask the set to fill in a given (integer) rect at a given content scale and then get back the set of tiles/rects/texture coordinates to generate that set. Using an integer rect allows textures at different contents scales to fill a piece of geometry without cracks. R=nduca@chromium.org BUG=155209 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=169083

Patch Set 1 #

Patch Set 2 : Fix win_rel #

Unified diffs Side-by-side diffs Delta from patch set Stats (+709 lines, -112 lines) Patch
M cc/cc.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M cc/cc_tests.gyp View 2 chunks +5 lines, -0 lines 0 comments Download
M cc/picture_layer.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/picture_layer.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M cc/picture_layer_impl.h View 2 chunks +2 lines, -1 line 0 comments Download
M cc/picture_layer_impl.cc View 4 chunks +13 lines, -25 lines 0 comments Download
M cc/picture_layer_tiling.h View 2 chunks +26 lines, -16 lines 0 comments Download
M cc/picture_layer_tiling.cc View 6 chunks +155 lines, -62 lines 0 comments Download
A cc/picture_layer_tiling_set.h View 1 chunk +76 lines, -0 lines 0 comments Download
A cc/picture_layer_tiling_set.cc View 1 1 chunk +157 lines, -0 lines 0 comments Download
A cc/picture_layer_tiling_set_unittest.cc View 1 chunk +44 lines, -0 lines 0 comments Download
A cc/picture_layer_tiling_unittest.cc View 1 1 chunk +121 lines, -0 lines 0 comments Download
M cc/region.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/region.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M cc/scoped_ptr_vector.h View 1 chunk +4 lines, -0 lines 0 comments Download
A cc/test/fake_picture_layer_tiling_client.h View 1 chunk +38 lines, -0 lines 0 comments Download
A cc/test/fake_picture_layer_tiling_client.cc View 1 chunk +30 lines, -0 lines 0 comments Download
A cc/test/fake_tile_manager_client.h View 1 chunk +22 lines, -0 lines 0 comments Download
M cc/tile.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/tile_manager.h View 3 chunks +3 lines, -3 lines 0 comments Download
M cc/tile_manager.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
enne (OOO)
This was getting large, so I thought I'd put it up for review. Is this ...
8 years, 1 month ago (2012-11-21 02:15:21 UTC) #1
nduca
The iterator makes sense, actually. I was concerned when we were considering something ~= kd ...
8 years, 1 month ago (2012-11-21 07:12:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/11417111/1
8 years, 1 month ago (2012-11-21 14:44:04 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
8 years, 1 month ago (2012-11-21 15:38:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/11417111/6004
8 years, 1 month ago (2012-11-21 17:05:37 UTC) #5
commit-bot: I haz the power
8 years, 1 month ago (2012-11-21 19:15:31 UTC) #6
Change committed as 169083

Powered by Google App Engine
This is Rietveld 408576698