Add quiet mode settings bubble.

Add quiet mode settings bubble.


BUG=161096
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=169177

[miket_OOO, 2012-11-21 01:18:21]

lgtm

https://codereview.chromium.org/11417103/diff/1/ui/message_center/quiet_mode_...
File ui/message_center/quiet_mode_bubble.cc (right):

https://codereview.chromium.org/11417103/diff/1/ui/message_center/quiet_mode_...
ui/message_center/quiet_mode_bubble.cc:1: #include
"ui/message_center/quiet_mode_bubble.h"
License header missing!

https://codereview.chromium.org/11417103/diff/1/ui/message_center/quiet_mode_...
ui/message_center/quiet_mode_bubble.cc:110: }  // namespace messge_center
spelling

https://codereview.chromium.org/11417103/diff/1/ui/message_center/quiet_mode_...
File ui/message_center/quiet_mode_bubble.h (right):

https://codereview.chromium.org/11417103/diff/1/ui/message_center/quiet_mode_...
ui/message_center/quiet_mode_bubble.h:22: // nor MessageBubbleBase because it's
UI is slightly different.
or ("neither...nor" or "is not A or B")

its (no apostrophe)

one space after period.

https://codereview.chromium.org/11417103/diff/1/ui/message_center/quiet_mode_...
ui/message_center/quiet_mode_bubble.h:46: // Buttons.  used in ButtonPressed()
to check which button is pressed.
One space after period. Capitalize "used."

[Jun Mukai, 2012-11-21 19:33:06]

https://codereview.chromium.org/11417103/diff/1/ui/message_center/quiet_mode_...
File ui/message_center/quiet_mode_bubble.cc (right):

https://codereview.chromium.org/11417103/diff/1/ui/message_center/quiet_mode_...
ui/message_center/quiet_mode_bubble.cc:1: #include
"ui/message_center/quiet_mode_bubble.h"
On 2012/11/21 01:18:21, miket wrote:
> License header missing!

Done. Sorry...

https://codereview.chromium.org/11417103/diff/1/ui/message_center/quiet_mode_...
ui/message_center/quiet_mode_bubble.cc:110: }  // namespace messge_center
On 2012/11/21 01:18:21, miket wrote:
> spelling

Done.

https://codereview.chromium.org/11417103/diff/1/ui/message_center/quiet_mode_...
File ui/message_center/quiet_mode_bubble.h (right):

https://codereview.chromium.org/11417103/diff/1/ui/message_center/quiet_mode_...
ui/message_center/quiet_mode_bubble.h:22: // nor MessageBubbleBase because it's
UI is slightly different.
On 2012/11/21 01:18:21, miket wrote:
> or ("neither...nor" or "is not A or B")
> 
> its (no apostrophe)
> 
> one space after period.

Done.

https://codereview.chromium.org/11417103/diff/1/ui/message_center/quiet_mode_...
ui/message_center/quiet_mode_bubble.h:46: // Buttons.  used in ButtonPressed()
to check which button is pressed.
On 2012/11/21 01:18:21, miket wrote:
> One space after period. Capitalize "used."

Done.

[commit-bot: I haz the power, 2012-11-21 19:34:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mukai@chromium.org/11417103/5001

[commit-bot: I haz the power, 2012-11-21 19:35:00]

Presubmit check for 11417103-5001 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    ui

[Jun Mukai, 2012-11-21 21:09:08]

sky, could you give me the owner approval for ui/base/strings?

[sky, 2012-11-21 22:54:30]

LGTM

[commit-bot: I haz the power, 2012-11-21 22:55:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mukai@chromium.org/11417103/5001

[commit-bot: I haz the power, 2012-11-22 00:48:10]

Change committed as 169177