Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5974)

Unified Diff: chrome/common/cancelable_task_tracker.cc

Issue 11417077: Rewrite CancelableTaskTracker unit tests (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comments Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/cancelable_task_tracker.h ('k') | chrome/common/cancelable_task_tracker_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/cancelable_task_tracker.cc
diff --git a/chrome/common/cancelable_task_tracker.cc b/chrome/common/cancelable_task_tracker.cc
index 3ac71afe36fb842661494b5454ae4a1e32fb894a..c8a6bbb41866109499a29f024a3ecf0aa8dfbbd2 100644
--- a/chrome/common/cancelable_task_tracker.cc
+++ b/chrome/common/cancelable_task_tracker.cc
@@ -61,6 +61,8 @@ CancelableTaskTracker::CancelableTaskTracker()
next_id_(1) {}
CancelableTaskTracker::~CancelableTaskTracker() {
+ DCHECK(thread_checker_.CalledOnValidThread());
+
TryCancelAll();
}
@@ -68,6 +70,8 @@ CancelableTaskTracker::TaskId CancelableTaskTracker::PostTask(
TaskRunner* task_runner,
const tracked_objects::Location& from_here,
const Closure& task) {
+ DCHECK(thread_checker_.CalledOnValidThread());
+
return PostTaskAndReply(task_runner, from_here, task, Bind(&base::DoNothing));
}
@@ -159,6 +163,8 @@ void CancelableTaskTracker::TryCancelAll() {
}
void CancelableTaskTracker::Track(TaskId id, CancellationFlag* flag) {
+ DCHECK(thread_checker_.CalledOnValidThread());
+
bool success = task_flags_.insert(std::make_pair(id, flag)).second;
DCHECK(success);
}
« no previous file with comments | « chrome/common/cancelable_task_tracker.h ('k') | chrome/common/cancelable_task_tracker_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698