content/components/navigation_interception/intercept_navigation_resource_throttle.cc - Issue 11417061: [android_webview] Enable navigation interception for iframes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/components/navigation_interception/intercept_navigation_resource_throttle.cc

Issue 11417061: [android_webview] Enable navigation interception for iframes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: address Mikhail's comments Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.cc ('K') | « android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldIgnoreNavigationTest.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/components/navigation_interception/intercept_navigation_resource_throttle.cc

diff --git a/content/components/navigation_interception/intercept_navigation_resource_throttle.cc b/content/components/navigation_interception/intercept_navigation_resource_throttle.cc

index 894fb0c1a98f20dd74e37f96891f92496961f611..68a67e2c713f9ff370b80689e287fabb4c3fbf68 100644

--- a/content/components/navigation_interception/intercept_navigation_resource_throttle.cc

+++ b/content/components/navigation_interception/intercept_navigation_resource_throttle.cc

@@ -94,9 +94,6 @@ bool InterceptNavigationResourceThrottle::CheckIfShouldIgnoreNavigation(

if (!info->GetAssociatedRenderView(&render_process_id, &render_view_id))

return false;

- // This class should only be instantiated for top level frame requests.

- DCHECK(info->IsMainFrame());

ShouldIgnoreCallbackParams params;

params.render_process_id = render_process_id;

params.render_view_id = render_view_id;