[android_webview] Enable navigation interception for iframes.

[android_webview] Enable navigation interception for iframes.

This enables navigation interception for navigations in iframes.
The feature is limited to iframes that do not have a http(s) source.

BUG=None


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=168811

[mkosiba (inactive), 2012-11-19 13:14:27]

jknotten@ for throttle changes
mnaganov@ for android_webview changes

[mnaganov (inactive), 2012-11-19 13:29:10]

LGTM with 1 question for android_webview

https://codereview.chromium.org/11417061/diff/1/android_webview/javatests/src...
File
android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldIgnoreNavigationTest.java
(right):

https://codereview.chromium.org/11417061/diff/1/android_webview/javatests/src...
android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldIgnoreNavigationTest.java:574:
// Wait for the redirect target URL to be fetched from the server.
Does it make sense to check that
mWebServer.getRequestCount(REDIRECT_TARGET_PATH) != 1 (or maybe == 0) prior to
entering this poll loop?

[mkosiba (inactive), 2012-11-19 13:47:21]

https://codereview.chromium.org/11417061/diff/1/android_webview/javatests/src...
File
android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldIgnoreNavigationTest.java
(right):

https://codereview.chromium.org/11417061/diff/1/android_webview/javatests/src...
android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldIgnoreNavigationTest.java:574:
// Wait for the redirect target URL to be fetched from the server.
On 2012/11/19 13:29:10, Mikhail Naganov (Chromium) wrote:
> Does it make sense to check that
> mWebServer.getRequestCount(REDIRECT_TARGET_PATH) != 1 (or maybe == 0) prior to
> entering this poll loop?

Done.

[John Knottenbelt, 2012-11-19 14:09:03]

LGTM. Is the BUG= intentionally blank?

https://codereview.chromium.org/11417061/diff/3002/android_webview/browser/re...
File
android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.cc
(right):

https://codereview.chromium.org/11417061/diff/3002/android_webview/browser/re...
android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.cc:134:
// We ignore POST requests because of BUG=155250.
Can you elaborate a little here why we ignore POST requests. It would be great
to be able to understand without having to go to the bug. Having gone to the
bug, I still didn't really understand why POST requests don't work.

[commit-bot: I haz the power, 2012-11-20 13:45:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mkosiba@chromium.org/11417061/9005

[commit-bot: I haz the power, 2012-11-20 15:54:18]

Retried try job too often for step(s) content_unittests

[commit-bot: I haz the power, 2012-11-20 16:04:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mkosiba@chromium.org/11417061/9005

[commit-bot: I haz the power, 2012-11-20 16:40:30]

Change committed as 168811

[joth, 2012-11-20 20:08:02]

hahaha wondered why you hadn't replied to these: I never sent them! nothing
critical for this patch though.

https://chromiumcodereview.appspot.com/11417061/diff/3002/android_webview/bro...
File
android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.cc
(right):

https://chromiumcodereview.appspot.com/11417061/diff/3002/android_webview/bro...
android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.cc:143:
// embedder.
is this a sane thing to support long term? if not, we might want to allow the
glue layer to choose if we do this, and disable it for apps targeting some
future version.

https://chromiumcodereview.appspot.com/11417061/diff/3002/android_webview/bro...
android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.cc:147:
!request->url().SchemeIs(chrome::kHttpsScheme)));
nit: maybe easier to read as.

bool allow_intercepting = resource_type == ResourceType::MAIN_FRAME;

if (is allowable sub frame) {
  allow_intercepting = true;
}