Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issue 11417059: Reset to correct version when switching upstream repository for a git dependency. (Closed)

Created:
8 years, 1 month ago by Bernhard Bauer
Modified:
8 years, 1 month ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, Dirk Pranke, cmp+cc_chromium.org, M-A Ruel, TVL
Visibility:
Public.

Description

Reset to correct version when switching upstream repository for a git dependency. This avoids build errors like at http://build.chromium.org/p/tryserver.chromium/builders/linux_clang/builds/64851/steps/update/logs/stdio (search for mtpd). BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=168521

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M gclient_scm.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Bernhard Bauer
Please review.
8 years, 1 month ago (2012-11-19 10:31:25 UTC) #1
M-A Ruel
lgtm, origin is quite badly hardcoded too.
8 years, 1 month ago (2012-11-19 14:07:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bauerb@chromium.org/11417059/1
8 years, 1 month ago (2012-11-19 14:08:49 UTC) #3
commit-bot: I haz the power
8 years, 1 month ago (2012-11-19 14:11:37 UTC) #4
Change committed as 168521

Powered by Google App Engine
This is Rietveld 408576698