Retry: Add a first test for tools/deep_memory_profiler.

Retry: Add a first test for tools/deep_memory_profiler.


BUG=123749
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=168979

[Dai Mikurube (NOT FULLTIME), 2012-11-17 20:27:41]

Hi,

I think this patch has a good permission.  Could you take a look when you have
time?

[M-A Ruel, 2012-11-17 23:23:10]

http://codereview.chromium.org/11417048/diff/1/tools/deep_memory_profiler/dmp...
File tools/deep_memory_profiler/dmprof.py (left):

http://codereview.chromium.org/11417048/diff/1/tools/deep_memory_profiler/dmp...
tools/deep_memory_profiler/dmprof.py:1: #!/usr/bin/env python
Why are you removing the shebang and removing the executable bit on this file?

[Dai Mikurube (NOT FULLTIME), 2012-11-18 06:01:54]

http://codereview.chromium.org/11417048/diff/1/tools/deep_memory_profiler/dmp...
File tools/deep_memory_profiler/dmprof.py (left):

http://codereview.chromium.org/11417048/diff/1/tools/deep_memory_profiler/dmp...
tools/deep_memory_profiler/dmprof.py:1: #!/usr/bin/env python
On 2012/11/17 23:23:10, Marc-Antoine Ruel wrote:
> Why are you removing the shebang and removing the executable bit on this file?

It's because now dmprof can be executed by the shell script.  I thought we'd be
happy to have required minimum executable files.

[Dai Mikurube (NOT FULLTIME), 2012-11-20 04:15:22]

gentle ping...

[M-A Ruel, 2012-11-20 14:34:03]

lgtm, sorry

[commit-bot: I haz the power, 2012-11-21 02:26:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dmikurube@chromium.org/11417048/1

[Dai Mikurube (NOT FULLTIME), 2012-11-21 02:26:46]

Thanks.  Committing via CQ.

[commit-bot: I haz the power, 2012-11-21 04:45:30]

Change committed as 168979

[M-A Ruel, 2012-11-21 08:54:11]

On 2012/11/21 04:45:30, I haz the power (commit-bot) wrote:
> Change committed as 168979

Wouah, looks like the CQ didn't apply the patch properly. Filed
http://code.google.com/p/chromium/issues/detail?id=162196