Teach install-build-deps.sh --arm how to install the arm root image.

Teach "install-build-deps.sh --arm" how to install the arm root image.

The --arm argument will already install the arm cross
toolchain, but building chrome/arm also requires an
arm sysroot.  The script will now download the sysroot
to out/arm_root.

BUG=


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=171448

[Sam Clegg, 2012-11-16 22:09:43]

This change is part of the effort to get an arm/chrome
buildbot up and running.  I suppose this logic could
be put directly into the buildbot script but its useful
for developers to be able to build chrome/arm locally
and consistently too.

I'm not sure if "out" is the right place for the arm_root
to live.

[Sam Clegg, 2012-11-16 22:10:10]

On 2012/11/16 22:09:43, Sam Clegg wrote:
> This change is part of the effort to get an arm/chrome
> buildbot up and running.  I suppose this logic could
> be put directly into the buildbot script but its useful
> for developers to be able to build chrome/arm locally
> and consistently too.
> 
> I'm not sure if "out" is the right place for the arm_root
> to live.

The root image is 27Mb BTW.

[Nico, 2012-11-16 23:30:45]

I don't know who usually reviews install-build-deps changes. I think Tony or
Lei, so + them.

[Lei Zhang, 2012-11-16 23:43:38]

https://codereview.chromium.org/11417041/diff/1/build/install-build-deps.sh
File build/install-build-deps.sh (right):

https://codereview.chromium.org/11417041/diff/1/build/install-build-deps.sh#n...
build/install-build-deps.sh:209:
tarball=$(pwd)/out/naclsdk_linux_arm-trusted.tgz
Do you need to keep the tarball afterwards? Can you put in a tmp dir and then
delete it after untarring?

[tony, 2012-11-16 23:50:06]

It feels a bit weird to me that if I clobber my build by doing an rm -rf out, I
have to re-run install-build-deps.sh.

I don't have an better ideas, so I guess this is OK.  I was going to suggest a
gclient hook, but it doesn't look like hooks know that you're targeting arm.

https://codereview.chromium.org/11417041/diff/1/build/install-build-deps.sh
File build/install-build-deps.sh (right):

https://codereview.chromium.org/11417041/diff/1/build/install-build-deps.sh#n...
build/install-build-deps.sh:213: curl -L \
It seems like at this point, curl hasn't been installed by this script yet.

[Nico, 2012-11-16 23:51:38]

On Fri, Nov 16, 2012 at 3:50 PM,  <tony@chromium.org> wrote:
> It feels a bit weird to me that if I clobber my build by doing an rm -rf
> out, I
> have to re-run install-build-deps.sh.
>
> I don't have an better ideas, so I guess this is OK.  I was going to suggest
> a
> gclient hook, but it doesn't look like hooks know that you're targeting arm.

android has this `target_os = ['android']` in their .gclient and makes
some decisions based off that. Could that work here?

>
>
>
> https://codereview.chromium.org/11417041/diff/1/build/install-build-deps.sh
> File build/install-build-deps.sh (right):
>
>
https://codereview.chromium.org/11417041/diff/1/build/install-build-deps.sh#n...
> build/install-build-deps.sh:213: curl -L \
> It seems like at this point, curl hasn't been installed by this script
> yet.
>
> https://codereview.chromium.org/11417041/

[Sam Clegg, 2012-11-17 00:01:23]

On 2012/11/16 23:51:38, Nico wrote:
> On Fri, Nov 16, 2012 at 3:50 PM,  <mailto:tony@chromium.org> wrote:
> > It feels a bit weird to me that if I clobber my build by doing an rm -rf
> > out, I
> > have to re-run install-build-deps.sh.
> >
> > I don't have an better ideas, so I guess this is OK.  I was going to suggest
> > a
> > gclient hook, but it doesn't look like hooks know that you're targeting arm.
> 
> android has this `target_os = ['android']` in their .gclient and makes
> some decisions based off that. Could that work here?
> 
> >
> >
> >
> > https://codereview.chromium.org/11417041/diff/1/build/install-build-deps.sh
> > File build/install-build-deps.sh (right):
> >
> >
>
https://codereview.chromium.org/11417041/diff/1/build/install-build-deps.sh#n...
> > build/install-build-deps.sh:213: curl -L \
> > It seems like at this point, curl hasn't been installed by this script
> > yet.
> >
> > https://codereview.chromium.org/11417041/

Perhaps install-build-deps.sh should be reserved for OS/package
stuff and a new script (download-arm-sysroot.sh) could be invoked at gyp time as
needed?

[Sam Clegg, 2012-12-04 00:56:41]

On 2012/11/17 00:01:23, Sam Clegg wrote:
> On 2012/11/16 23:51:38, Nico wrote:
> > On Fri, Nov 16, 2012 at 3:50 PM,  <mailto:tony@chromium.org> wrote:
> > > It feels a bit weird to me that if I clobber my build by doing an rm -rf
> > > out, I
> > > have to re-run install-build-deps.sh.
> > >
> > > I don't have an better ideas, so I guess this is OK.  I was going to
suggest
> > > a
> > > gclient hook, but it doesn't look like hooks know that you're targeting
arm.
> > 
> > android has this `target_os = ['android']` in their .gclient and makes
> > some decisions based off that. Could that work here?
> > 
> > >
> > >
> > >
> > >
https://codereview.chromium.org/11417041/diff/1/build/install-build-deps.sh
> > > File build/install-build-deps.sh (right):
> > >
> > >
> >
>
https://codereview.chromium.org/11417041/diff/1/build/install-build-deps.sh#n...
> > > build/install-build-deps.sh:213: curl -L \
> > > It seems like at this point, curl hasn't been installed by this script
> > > yet.
> > >
> > > https://codereview.chromium.org/11417041/
> 
> Perhaps install-build-deps.sh should be reserved for OS/package
> stuff and a new script (download-arm-sysroot.sh) could be invoked at gyp time
as
> needed?

PTAL

I agree that having the sysroot inside "out" is a bad idea.

I considered several options to address this, including modifying
install_chroot.py to build the arm root image from scratch on each
machine, but I decided it is better to use a standard/consistent
root image in the default case.   (I can commit my mods to
install_chroot.py separately if you think its a good idea).

So my solution is to install to arm-sysroot in the root of the chrome
checkout. I also added a timestamp so that it won't re-download when this script
is re-run.

[tony, 2012-12-04 02:25:36]

Did you try and see if target_os in the .gclient file would work here?

[Sam Clegg, 2012-12-04 03:15:26]

On 2012/12/04 02:25:36, tony wrote:
> Did you try and see if target_os in the .gclient file would work here?

I'm not sure how that would work.  Can you explain or point me to an example?  
Are you suggesting that we could inspect GYP_DEFINES at some point in the
gclient hooks?

[Sam Clegg, 2012-12-04 03:22:25]

On 2012/12/04 03:15:26, Sam Clegg wrote:
> On 2012/12/04 02:25:36, tony wrote:
> > Did you try and see if target_os in the .gclient file would work here?
> 
> I'm not sure how that would work.  Can you explain or point me to an example? 

> Are you suggesting that we could inspect GYP_DEFINES at some point in the
> gclient hooks?

OK, I see what you are talking about now.  The gclient deps can depend
on the target_os.  However, I don't think that would work in this example for a
couple of reasons.  Firstly it seems that you can have deps_os but there is no
support hooks_os as far as I can tell.  Also the target_os in this case is still
linux, its really the target arch that are interested in detected in the run
hooks.

[tony, 2012-12-04 20:59:42]

OK, LGTM

[Sam Clegg, 2012-12-05 23:18:07]

Fixed issues raised by Lei. PTAL.

https://chromiumcodereview.appspot.com/11417041/diff/1/build/install-build-de...
File build/install-build-deps.sh (right):

https://chromiumcodereview.appspot.com/11417041/diff/1/build/install-build-de...
build/install-build-deps.sh:209:
tarball=$(pwd)/out/naclsdk_linux_arm-trusted.tgz
On 2012/11/16 23:43:38, Lei Zhang wrote:
> Do you need to keep the tarball afterwards? Can you put in a tmp dir and then
> delete it after untarring?

Done.

https://chromiumcodereview.appspot.com/11417041/diff/1/build/install-build-de...
build/install-build-deps.sh:213: curl -L \
On 2012/11/16 23:50:06, tony wrote:
> It seems like at this point, curl hasn't been installed by this script yet.

Done.

[commit-bot: I haz the power, 2012-12-06 04:15:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sbc@chromium.org/11417041/20001

[commit-bot: I haz the power, 2012-12-06 08:31:25]

Change committed as 171448