Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 11417038: IsFileInUse should return false when the file doesn't exist. (Closed)

Created:
8 years, 1 month ago by grt (UTC plus 2)
Modified:
8 years, 1 month ago
Reviewers:
robertshield
CC:
chromium-reviews, grt+watch_chromium.org
Visibility:
Public.

Description

IsFileInUse should return false when the file doesn't exist. BUG=98195 TEST=install chrome, delete the installation dir without uninstalling, then install again. hope that chrome.exe is in place rather than new_chrome.exe. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=168548

Patch Set 1 #

Patch Set 2 : sync past r168281 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -4 lines) Patch
M chrome/installer/util/installer_state.cc View 2 chunks +8 lines, -4 lines 0 comments Download
M chrome/installer/util/installer_state_unittest.cc View 1 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
grt (UTC plus 2)
8 years, 1 month ago (2012-11-16 20:20:19 UTC) #1
robertshield
lgtm
8 years, 1 month ago (2012-11-16 20:25:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grt@chromium.org/11417038/1
8 years, 1 month ago (2012-11-16 20:42:30 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
8 years, 1 month ago (2012-11-16 22:05:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grt@chromium.org/11417038/10001
8 years, 1 month ago (2012-11-19 15:04:02 UTC) #5
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
8 years, 1 month ago (2012-11-19 15:05:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grt@chromium.org/11417038/10001
8 years, 1 month ago (2012-11-19 16:25:30 UTC) #7
commit-bot: I haz the power
8 years, 1 month ago (2012-11-19 17:47:40 UTC) #8
Change committed as 168548

Powered by Google App Engine
This is Rietveld 408576698