Chromium Code Reviews
Help | Chromium Project | Sign in
(1028)

Issue 11417036: Fix user-level Chrome self-destruction issues on Windows 8. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 5 months ago by gab
Modified:
1 year, 5 months ago
Reviewers:
Nico, robertshield, grt
CC:
chromium-reviews_chromium.org, grt+watch_chromium.org
Visibility:
Public.

Description

Remove self-destruct message box (causing hang in Metro).

Launch self-destruct setup out of job (so that it doesn't die when killing the chrome.exe which created it...).

And be more drastic about killing Chrome processes on force-uninstall (pure kill, no wait).


BUG=158632, 159995
TEST=Install system-level over user-level (with user-level set to run in Metro mode); next run should self-destruct user-level Chrome (silently); subsequent launches should launch system-level Chrome.
This should also fix users currently in this bad state (upon updating the user-level Chrome which will then be able to self-destruct properly).

This might also solve bug 159995, will need to test with official build (it definitely solves the part where when both Chromes are present, user-level is activated, but hangs on the self-destruct message (which can't be displayed in Metro) -- the stronger kill process in this CL might also help with the user-level binaries left behind issue).


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=169130

Patch Set 1 #

Total comments: 10

Patch Set 2 : Also kill delegate_execute.exe. #

Patch Set 3 : Kill delegate_execute only on Win8 and only remove dialog on Win8/Metro #

Total comments: 2

Patch Set 4 : dont rm delegate_execute and only breakaway if Metro #

Patch Set 5 : rebase on master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -36 lines) Lint Patch
M chrome/browser/chrome_browser_main_win.cc View 1 2 3 1 chunk +16 lines, -6 lines 0 comments 1 errors Download
M chrome/installer/setup/uninstall.cc View 2 3 4 1 chunk +3 lines, -30 lines 0 comments ? errors Download
Commit:

Messages

Total messages: 14
gab
Sirs, this is going to stable so I'd like a double-review (although this is fairly ...
1 year, 5 months ago #1
robertshield
https://codereview.chromium.org/11417036/diff/1/chrome/browser/chrome_browser_main_win.cc File chrome/browser/chrome_browser_main_win.cc (left): https://codereview.chromium.org/11417036/diff/1/chrome/browser/chrome_browser_main_win.cc#oldcode368 chrome/browser/chrome_browser_main_win.cc:368: ui::MessageBox(NULL, text, caption, flags); Let's only remove this on ...
1 year, 5 months ago #2
grt
https://codereview.chromium.org/11417036/diff/1/chrome/browser/chrome_browser_main_win.cc File chrome/browser/chrome_browser_main_win.cc (left): https://codereview.chromium.org/11417036/diff/1/chrome/browser/chrome_browser_main_win.cc#oldcode368 chrome/browser/chrome_browser_main_win.cc:368: ui::MessageBox(NULL, text, caption, flags); On 2012/11/16 20:23:33, robertshield wrote: ...
1 year, 5 months ago #3
gab
PTAL. CloseChromeFrameHelperProcess() already takes care of the Chrome Frame related processes; however it only does ...
1 year, 5 months ago #4
robertshield
lgtm
1 year, 5 months ago #5
grt
https://codereview.chromium.org/11417036/diff/1/chrome/installer/setup/uninstall.cc File chrome/installer/setup/uninstall.cc (right): https://codereview.chromium.org/11417036/diff/1/chrome/installer/setup/uninstall.cc#newcode190 chrome/installer/setup/uninstall.cc:190: base::CleanupProcesses(installer::kChromeExe, base::TimeDelta(), On 2012/11/20 00:46:36, gab wrote: > On ...
1 year, 5 months ago #6
gab
PTAL https://codereview.chromium.org/11417036/diff/1/chrome/installer/setup/uninstall.cc File chrome/installer/setup/uninstall.cc (right): https://codereview.chromium.org/11417036/diff/1/chrome/installer/setup/uninstall.cc#newcode194 chrome/installer/setup/uninstall.cc:194: } On 2012/11/20 02:35:38, grt wrote: > On ...
1 year, 5 months ago #7
grt
lgtm
1 year, 5 months ago #8
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gab@chromium.org/11417036/1004
1 year, 5 months ago #9
I haz the power (commit-bot)
Presubmit check for 11417036-1004 failed and returned exit status 1. Running presubmit commit checks ...
1 year, 5 months ago #10
gab
@Nico for chrome/browser/chrome_browser_main_win.cc Thanks, Gab
1 year, 5 months ago #11
Nico
lgtm stamp
1 year, 5 months ago #12
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gab@chromium.org/11417036/1004
1 year, 5 months ago #13
I haz the power (commit-bot)
1 year, 5 months ago #14
Change committed as 169130
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6