src/builtins.cc - Issue 11417007: Fix shifting from holey arrays.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/builtins.cc

Issue 11417007: Fix shifting from holey arrays. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Addressed comment Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/builtins.cc

diff --git a/src/builtins.cc b/src/builtins.cc

index 6617fe1ad9738b80c72912c9984504a4d01ff3ce..88918cff08bbf64043f139ea192c98e86866eefb 100644

--- a/src/builtins.cc

+++ b/src/builtins.cc

@@ -711,6 +711,9 @@ BUILTIN(ArrayShift) {

Object* first;

MaybeObject* maybe_first = accessor->Get(receiver, array, 0, elms_obj);

if (!maybe_first->To(&first)) return maybe_first;

+ if (first->IsTheHole()) {

+ first = heap->undefined_value();

+ }

if (!heap->lo_space()->Contains(elms_obj)) {

array->set_elements(LeftTrimFixedArray(heap, elms_obj, 1));

« no previous file with comments | « no previous file | no next file » | no next file with comments »