Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 11416385: Cleaning up ImeAdapter.java (Closed)

Created:
8 years ago by aurimas (slooooooooow)
Modified:
8 years ago
Reviewers:
Yusuf, Jay Civelli
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Cleaning up ImeAdapter.java Cleaning up ImeAdapter to user BaseInputConnection's getEditable() instead of using the private member variable mEditable. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173075

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -35 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/ImeAdapter.java View 9 chunks +27 lines, -35 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
aurimas (slooooooooow)
8 years ago (2012-12-12 23:09:10 UTC) #1
Yusuf
lgtm
8 years ago (2012-12-13 22:38:37 UTC) #2
aurimas (slooooooooow)
Oh hey Jay! I need an LGTM from an owner of content/public/android/. Could you take ...
8 years ago (2012-12-13 22:49:14 UTC) #3
Jay Civelli
lgtm
8 years ago (2012-12-13 23:07:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/11416385/1
8 years ago (2012-12-13 23:24:38 UTC) #5
commit-bot: I haz the power
8 years ago (2012-12-14 04:01:28 UTC) #6
Message was sent while issue was closed.
Change committed as 173075

Powered by Google App Engine
This is Rietveld 408576698