Refactored Android samples / embedder.

samples/android_sample/jni/android_extension.cc

Index: samples/android_sample/jni/android_extension.cc
diff --git a/samples/android_sample/jni/android_extension.cc b/samples/android_sample/jni/android_extension.cc
index 0027571d0900617648524c3c7e4c6bb370835e59..3ea899ec79cad537442b31dad31f6eb1ead786ba 100644
--- a/samples/android_sample/jni/android_extension.cc
+++ b/samples/android_sample/jni/android_extension.cc
@@ -11,10 +11,9 @@
 #include <stdlib.h>
 #include <string.h>
 
-#include "bin/log.h"
 #include "include/dart_api.h"
-
-Dart_NativeFunction ResolveName(Dart_Handle name, int argc);
+#include "jni/android_extension.h"

[gram, 2012/12/04 22:03:42]

Thsi should come first:
http://www.corp.google.com/eng/doc/cppguide.xml#Names_and_Order_of_Includes

[vsm, 2012/12/04 23:03:08]

Done.

+#include "jni/log.h"
 
 DART_EXPORT Dart_Handle android_extension_Init(Dart_Handle parent_library) {
   if (Dart_IsError(parent_library)) { return parent_library; }
@@ -33,7 +32,7 @@ Dart_Handle HandleError(Dart_Handle handle) {
 void CheckGLError(const char *function) {
   int error = glGetError();
   if (error != GL_NO_ERROR) {
-    Log::PrintErr("ERROR!: %s returns %d", function, error);
+    LOGE("ERROR!: %s returns %d", function, error);
   }
 }
 
@@ -45,7 +44,7 @@ void Log(Dart_NativeArguments arguments) {
   uint8_t* str[1];
   HandleError(Dart_StringToUTF8(whatHandle, &str[0], length));
   str[0][*length] = 0;
-  Log::Print(const_cast<const GLchar*>(reinterpret_cast<GLchar*>(str[0])));
+  LOGI(const_cast<const GLchar*>(reinterpret_cast<GLchar*>(str[0])));
   Dart_ExitScope();
 }
 
@@ -75,7 +74,7 @@ void SystemSrand(Dart_NativeArguments arguments) {
 }
 
 void EGLSwapBuffers(Dart_NativeArguments arguments) {
-  Log::Print("GLSwapBuffers");
+  LOGI("GLSwapBuffers");
   Dart_EnterScope();
 
   EGLDisplay display = eglGetDisplay(EGL_DEFAULT_DISPLAY);
@@ -87,7 +86,7 @@ void EGLSwapBuffers(Dart_NativeArguments arguments) {
 }
 
 void GLAttachShader(Dart_NativeArguments arguments) {
-  Log::Print("GLAttachShader");
+  LOGI("GLAttachShader");
   Dart_EnterScope();
 
   Dart_Handle programHandle = HandleError(Dart_GetNativeArgument(arguments, 0));
@@ -104,7 +103,7 @@ void GLAttachShader(Dart_NativeArguments arguments) {
 }
 
 void GLBindBuffer(Dart_NativeArguments arguments) {
-  Log::Print("GLBindBuffer");
+  LOGI("GLBindBuffer");
   Dart_EnterScope();
 
   Dart_Handle targetHandle = HandleError(Dart_GetNativeArgument(arguments, 0));
@@ -121,7 +120,7 @@ void GLBindBuffer(Dart_NativeArguments arguments) {
 }
 
 void GLBufferData(Dart_NativeArguments arguments) {
-  Log::Print("GLBufferData");
+  LOGI("GLBufferData");
   Dart_EnterScope();
 
   Dart_Handle targetHandle = HandleError(Dart_GetNativeArgument(arguments, 0));
@@ -132,7 +131,7 @@ void GLBufferData(Dart_NativeArguments arguments) {
   intptr_t size;
   HandleError(Dart_ListLength(dataHandle, &size));
 
-  Log::Print("Size: %d", size);
+  LOGI("Size: %d", size);
 
   // TODO(vsm): No guarantee that this is a float!
   float* data = reinterpret_cast<float*>(malloc(size * sizeof(float)));
@@ -141,7 +140,7 @@ void GLBufferData(Dart_NativeArguments arguments) {
     double value;
     Dart_DoubleValue(elemHandle, &value);
     data[i] = static_cast<float>(value);
-    Log::Print("Value[%d]: %f", i, data[i]);
+    LOGI("Value[%d]: %f", i, data[i]);
   }
 
   Dart_Handle usageHandle = HandleError(Dart_GetNativeArgument(arguments, 2));
@@ -161,14 +160,14 @@ void GLCompileShader(Dart_NativeArguments arguments) {
   int64_t shader;
   HandleError(Dart_IntegerToInt64(shaderHandle, &shader));
 
-  Log::Print("GLCompileShader");
+  LOGI("GLCompileShader");
   glCompileShader(shader);
   CheckGLError("glCompileShader");
   Dart_ExitScope();
 }
 
 void GLCreateBuffer(Dart_NativeArguments arguments) {
-  Log::Print("GLCreateBuffer");
+  LOGI("GLCreateBuffer");
   Dart_EnterScope();
   GLuint buffer;
 
@@ -180,7 +179,7 @@ void GLCreateBuffer(Dart_NativeArguments arguments) {
 }
 
 void GLCreateProgram(Dart_NativeArguments arguments) {
-  Log::Print("GLCreateProgram");
+  LOGI("GLCreateProgram");
   Dart_EnterScope();
 
   int64_t program = glCreateProgram();
@@ -198,7 +197,7 @@ void GLCreateShader(Dart_NativeArguments arguments) {
   HandleError(Dart_IntegerToInt64(typeHandle, &type));
 
   int64_t shader = glCreateShader((GLenum)type);
-  Log::Print("GLCreateShader");
+  LOGI("GLCreateShader");
   CheckGLError("glCreateShader");
   Dart_Handle result = HandleError(Dart_NewInteger(shader));
   Dart_SetReturnValue(arguments, result);
@@ -206,7 +205,7 @@ void GLCreateShader(Dart_NativeArguments arguments) {
 }
 
 void GLDrawArrays(Dart_NativeArguments arguments) {
-  Log::Print("GLDrawArrays");
+  LOGI("GLDrawArrays");
   Dart_EnterScope();
 
   Dart_Handle modeHandle = HandleError(Dart_GetNativeArgument(arguments, 0));
@@ -227,7 +226,7 @@ void GLDrawArrays(Dart_NativeArguments arguments) {
 }
 
 void GLEnableVertexAttribArray(Dart_NativeArguments arguments) {
-  Log::Print("GLEnableVertexAttribArray");
+  LOGI("GLEnableVertexAttribArray");
   Dart_EnterScope();
 
   Dart_Handle locationHandle =
@@ -241,7 +240,7 @@ void GLEnableVertexAttribArray(Dart_NativeArguments arguments) {
 }
 
 void GLGetAttribLocation(Dart_NativeArguments arguments) {
-  Log::Print("GLGetAttribLocation");
+  LOGI("GLGetAttribLocation");
   Dart_EnterScope();
 
   Dart_Handle programHandle = HandleError(Dart_GetNativeArgument(arguments, 0));
@@ -264,7 +263,7 @@ void GLGetAttribLocation(Dart_NativeArguments arguments) {
 }
 
 void GLGetError(Dart_NativeArguments arguments) {
-  Log::Print("GLGetError");
+  LOGI("GLGetError");
   Dart_EnterScope();
 
   int64_t error = glGetError();
@@ -274,7 +273,7 @@ void GLGetError(Dart_NativeArguments arguments) {
 }
 
 void GLGetProgramParameter(Dart_NativeArguments arguments) {
-  Log::Print("GLGetProgramParameter");
+  LOGI("GLGetProgramParameter");
   Dart_EnterScope();
 
   Dart_Handle programHandle = HandleError(Dart_GetNativeArgument(arguments, 0));
@@ -295,7 +294,7 @@ void GLGetProgramParameter(Dart_NativeArguments arguments) {
 }
 
 void GLGetShaderParameter(Dart_NativeArguments arguments) {
-  Log::Print("GLGetShaderParameter");
+  LOGI("GLGetShaderParameter");
   Dart_EnterScope();
 
   Dart_Handle shaderHandle = HandleError(Dart_GetNativeArgument(arguments, 0));
@@ -316,7 +315,7 @@ void GLGetShaderParameter(Dart_NativeArguments arguments) {
 }
 
 void GLGetShaderInfoLog(Dart_NativeArguments arguments) {
-  Log::Print("GLGetShaderInfoLog");
+  LOGI("GLGetShaderInfoLog");
   Dart_EnterScope();
 
   Dart_Handle shaderHandle = HandleError(Dart_GetNativeArgument(arguments, 0));
@@ -337,7 +336,7 @@ void GLGetShaderInfoLog(Dart_NativeArguments arguments) {
 }
 
 void GLGetProgramInfoLog(Dart_NativeArguments arguments) {
-  Log::Print("GLGetProgramInfoLog");
+  LOGI("GLGetProgramInfoLog");
   Dart_EnterScope();
 
   Dart_Handle programHandle = HandleError(Dart_GetNativeArgument(arguments, 0));
@@ -358,7 +357,7 @@ void GLGetProgramInfoLog(Dart_NativeArguments arguments) {
 }
 
 void GLGetUniformLocation(Dart_NativeArguments arguments) {
-  Log::Print("GLGetUniformLocation");
+  LOGI("GLGetUniformLocation");
   Dart_EnterScope();
 
   Dart_Handle programHandle = HandleError(Dart_GetNativeArgument(arguments, 0));
@@ -381,7 +380,7 @@ void GLGetUniformLocation(Dart_NativeArguments arguments) {
 }
 
 void GLLinkProgram(Dart_NativeArguments arguments) {
-  Log::Print("GLLinkProgram");
+  LOGI("GLLinkProgram");
   Dart_EnterScope();
 
   Dart_Handle programHandle = HandleError(Dart_GetNativeArgument(arguments, 0));
@@ -394,7 +393,7 @@ void GLLinkProgram(Dart_NativeArguments arguments) {
 }
 
 void GLShaderSource(Dart_NativeArguments arguments) {
-  Log::Print("GLShaderSource");
+  LOGI("GLShaderSource");
   Dart_EnterScope();
 
   Dart_Handle shaderHandle = HandleError(Dart_GetNativeArgument(arguments, 0));
@@ -404,15 +403,15 @@ void GLShaderSource(Dart_NativeArguments arguments) {
   Dart_Handle sourceHandle = HandleError(Dart_GetNativeArgument(arguments, 1));
   intptr_t length[1];
   HandleError(Dart_StringLength(sourceHandle, length));
-  Log::Print("Source length is %d", length[0]);
+  LOGI("Source length is %d", length[0]);
   uint8_t* str[1];
   HandleError(Dart_StringToUTF8(sourceHandle, &str[0], length));
-  Log::Print("Converted length is %d", length[0]);
+  LOGI("Converted length is %d", length[0]);
   str[0][*length] = 0;
 
   const GLchar* source =
       const_cast<const GLchar*>(reinterpret_cast<GLchar*>(str[0]));
-  Log::Print("Source: %s", source);
+  LOGI("Source: %s", source);
   glShaderSource(shader, 1,
       const_cast<const GLchar**>(reinterpret_cast<GLchar**>(str)), NULL);
   CheckGLError("glShaderSource");
@@ -420,7 +419,7 @@ void GLShaderSource(Dart_NativeArguments arguments) {
 }
 
 void GLUseProgram(Dart_NativeArguments arguments) {
-  Log::Print("GLUseProgram");
+  LOGI("GLUseProgram");
   Dart_EnterScope();
 
   Dart_Handle programHandle = HandleError(Dart_GetNativeArgument(arguments, 0));
@@ -433,7 +432,7 @@ void GLUseProgram(Dart_NativeArguments arguments) {
 }
 
 void GLUniform1i(Dart_NativeArguments arguments) {
-  Log::Print("GLUniform1i");
+  LOGI("GLUniform1i");
   Dart_EnterScope();
 
   Dart_Handle locationHandle =
@@ -451,7 +450,7 @@ void GLUniform1i(Dart_NativeArguments arguments) {
 }
 
 void GLUniform2i(Dart_NativeArguments arguments) {
-  Log::Print("GLUniform2i");
+  LOGI("GLUniform2i");
   Dart_EnterScope();
 
   Dart_Handle locationHandle =
@@ -473,7 +472,7 @@ void GLUniform2i(Dart_NativeArguments arguments) {
 }
 
 void GLUniform3i(Dart_NativeArguments arguments) {
-  Log::Print("GLUniform3i");
+  LOGI("GLUniform3i");
   Dart_EnterScope();
 
   Dart_Handle locationHandle =
@@ -499,7 +498,7 @@ void GLUniform3i(Dart_NativeArguments arguments) {
 }
 
 void GLUniform4i(Dart_NativeArguments arguments) {
-  Log::Print("GLUniform4i");
+  LOGI("GLUniform4i");
   Dart_EnterScope();
 
   Dart_Handle locationHandle =
@@ -529,7 +528,7 @@ void GLUniform4i(Dart_NativeArguments arguments) {
 }
 
 void GLUniform1f(Dart_NativeArguments arguments) {
-  Log::Print("GLUniform1f");
+  LOGI("GLUniform1f");
   Dart_EnterScope();
 
   Dart_Handle locationHandle =
@@ -547,7 +546,7 @@ void GLUniform1f(Dart_NativeArguments arguments) {
 }
 
 void GLUniform2f(Dart_NativeArguments arguments) {
-  Log::Print("GLUniform2f");
+  LOGI("GLUniform2f");
   Dart_EnterScope();
 
   Dart_Handle locationHandle =
@@ -569,7 +568,7 @@ void GLUniform2f(Dart_NativeArguments arguments) {
 }
 
 void GLUniform3f(Dart_NativeArguments arguments) {
-  Log::Print("GLUniform3f");
+  LOGI("GLUniform3f");
   Dart_EnterScope();
 
   Dart_Handle locationHandle =
@@ -595,7 +594,7 @@ void GLUniform3f(Dart_NativeArguments arguments) {
 }
 
 void GLUniform4f(Dart_NativeArguments arguments) {
-  Log::Print("GLUniform4f");
+  LOGI("GLUniform4f");
   Dart_EnterScope();
 
   Dart_Handle locationHandle =
@@ -625,7 +624,7 @@ void GLUniform4f(Dart_NativeArguments arguments) {
 }
 
 void GLUniform1iv(Dart_NativeArguments arguments) {
-  Log::Print("GLUniform1iv");
+  LOGI("GLUniform1iv");
   Dart_EnterScope();
 
   Dart_Handle locationHandle =
@@ -653,7 +652,7 @@ void GLUniform1iv(Dart_NativeArguments arguments) {
 }
 
 void GLUniform2iv(Dart_NativeArguments arguments) {
-  Log::Print("GLUniform2iv");
+  LOGI("GLUniform2iv");
   Dart_EnterScope();
 
   Dart_Handle locationHandle =
@@ -681,7 +680,7 @@ void GLUniform2iv(Dart_NativeArguments arguments) {
 }
 
 void GLUniform3iv(Dart_NativeArguments arguments) {
-  Log::Print("GLUniform3iv");
+  LOGI("GLUniform3iv");
   Dart_EnterScope();
 
   Dart_Handle locationHandle =
@@ -709,7 +708,7 @@ void GLUniform3iv(Dart_NativeArguments arguments) {
 }
 
 void GLUniform4iv(Dart_NativeArguments arguments) {
-  Log::Print("GLUniform4iv");
+  LOGI("GLUniform4iv");
   Dart_EnterScope();
 
   Dart_Handle locationHandle =
@@ -737,7 +736,7 @@ void GLUniform4iv(Dart_NativeArguments arguments) {
 }
 
 void GLUniform1fv(Dart_NativeArguments arguments) {
-  Log::Print("GLUniform1fv");
+  LOGI("GLUniform1fv");
   Dart_EnterScope();
 
   Dart_Handle locationHandle =
@@ -765,7 +764,7 @@ void GLUniform1fv(Dart_NativeArguments arguments) {
 }
 
 void GLUniform2fv(Dart_NativeArguments arguments) {
-  Log::Print("GLUniform2fv");
+  LOGI("GLUniform2fv");
   Dart_EnterScope();
 
   Dart_Handle locationHandle =
@@ -793,7 +792,7 @@ void GLUniform2fv(Dart_NativeArguments arguments) {
 }
 
 void GLUniform3fv(Dart_NativeArguments arguments) {
-  Log::Print("GLUniform3fv");
+  LOGI("GLUniform3fv");
   Dart_EnterScope();
 
   Dart_Handle locationHandle =
@@ -821,7 +820,7 @@ void GLUniform3fv(Dart_NativeArguments arguments) {
 }
 
 void GLUniform4fv(Dart_NativeArguments arguments) {
-  Log::Print("In GLUniform4fv");
+  LOGI("In GLUniform4fv");
   Dart_EnterScope();
 
   Dart_Handle locationHandle =
@@ -849,7 +848,7 @@ void GLUniform4fv(Dart_NativeArguments arguments) {
 }
 
 void GLViewport(Dart_NativeArguments arguments) {
-  Log::Print("GLViewport");
+  LOGI("GLViewport");
   Dart_EnterScope();
 
   Dart_Handle xHandle = HandleError(Dart_GetNativeArgument(arguments, 0));
@@ -868,7 +867,7 @@ void GLViewport(Dart_NativeArguments arguments) {
   int64_t height;
   HandleError(Dart_IntegerToInt64(heightHandle, &height));
 
-  Log::Print("Dimensions: [%ld, %ld, %ld, %ld]", x, y, width, height);
+  LOGI("Dimensions: [%ld, %ld, %ld, %ld]", x, y, width, height);
 
   glViewport(x, y, width, height);
   CheckGLError("glViewPort");
@@ -876,7 +875,7 @@ void GLViewport(Dart_NativeArguments arguments) {
 }
 
 void GLVertexAttribPointer(Dart_NativeArguments arguments) {
-  Log::Print("GLVertexAttribPointer");
+  LOGI("GLVertexAttribPointer");
   Dart_EnterScope();
 
   Dart_Handle indexHandle = HandleError(Dart_GetNativeArgument(arguments, 0));
@@ -912,7 +911,7 @@ void GLVertexAttribPointer(Dart_NativeArguments arguments) {
 }
 
 void GLClearColor(Dart_NativeArguments arguments) {
-  Log::Print("GLClearColor");
+  LOGI("GLClearColor");
   Dart_EnterScope();
 
   Dart_Handle redHandle = HandleError(Dart_GetNativeArgument(arguments, 0));
@@ -937,7 +936,7 @@ void GLClearColor(Dart_NativeArguments arguments) {
 }
 
 void GLClearDepth(Dart_NativeArguments arguments) {
-  Log::Print("GLClearDepth");
+  LOGI("GLClearDepth");
   Dart_EnterScope();
 
   Dart_Handle depthHandle = HandleError(Dart_GetNativeArgument(arguments, 0));
@@ -950,7 +949,7 @@ void GLClearDepth(Dart_NativeArguments arguments) {
 }
 
 void GLClear(Dart_NativeArguments arguments) {
-  Log::Print("GLClear");
+  LOGI("GLClear");
   Dart_EnterScope();
   Dart_Handle maskHandle = HandleError(Dart_GetNativeArgument(arguments, 0));
   int64_t mask;
@@ -961,7 +960,7 @@ void GLClear(Dart_NativeArguments arguments) {
 }
 
 void GLArrayBuffer(Dart_NativeArguments arguments) {
-  Log::Print("GLArrayBuffer");
+  LOGI("GLArrayBuffer");
   Dart_EnterScope();
   Dart_Handle result = HandleError(Dart_NewInteger(GL_ARRAY_BUFFER));
   Dart_SetReturnValue(arguments, result);
@@ -969,7 +968,7 @@ void GLArrayBuffer(Dart_NativeArguments arguments) {
 }
 
 void GLColorBufferBit(Dart_NativeArguments arguments) {
-  Log::Print("GLColorBuffer");
+  LOGI("GLColorBuffer");
   Dart_EnterScope();
   Dart_Handle result = HandleError(Dart_NewInteger(GL_COLOR_BUFFER_BIT));
   Dart_SetReturnValue(arguments, result);
@@ -977,7 +976,7 @@ void GLColorBufferBit(Dart_NativeArguments arguments) {
 }
 
 void GLCompileStatus(Dart_NativeArguments arguments) {
-  Log::Print("GLCompileStatus");
+  LOGI("GLCompileStatus");
   Dart_EnterScope();
   Dart_Handle result = HandleError(Dart_NewInteger(GL_COMPILE_STATUS));
   Dart_SetReturnValue(arguments, result);
@@ -985,7 +984,7 @@ void GLCompileStatus(Dart_NativeArguments arguments) {
 }
 
 void GLDepthBufferBit(Dart_NativeArguments arguments) {
-  Log::Print("GLDepthBufferBit");
+  LOGI("GLDepthBufferBit");
   Dart_EnterScope();
   Dart_Handle result = HandleError(Dart_NewInteger(GL_DEPTH_BUFFER_BIT));
   Dart_SetReturnValue(arguments, result);
@@ -1185,4 +1184,3 @@ Dart_NativeFunction ResolveName(Dart_Handle name, int argc) {
   Dart_ExitScope();
   return result;
 }
-