Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 11416342: Fixes theme includes for test_webkit_platform_support. I don't believe (Closed)

Created:
8 years ago by sky
Modified:
8 years ago
Reviewers:
tony
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

Fixes theme includes for test_webkit_platform_support. I don't believe the linux one is needed at all. Layout tests that try to set a default theme when USE_DEFAULT_RENDER_THEME is set won't work. I'll figure that out when we get further along. BUG=none TEST=none R=tony@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=171090

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M webkit/support/test_webkit_platform_support.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sky
I had fixed this in my webkit patch yesterday, but didn't realize the file is ...
8 years ago (2012-12-04 17:42:38 UTC) #1
tony
LGTM
8 years ago (2012-12-04 21:00:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/11416342/1
8 years ago (2012-12-04 21:40:30 UTC) #3
commit-bot: I haz the power
8 years ago (2012-12-05 00:10:00 UTC) #4
Message was sent while issue was closed.
Change committed as 171090

Powered by Google App Engine
This is Rietveld 408576698